You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/25 20:53:02 UTC
[GitHub] [arrow] emkornfield commented on a change in pull request #10142: ARROW-12517: [Go][Flight] Expose app metadata in flight client and server
emkornfield commented on a change in pull request #10142:
URL: https://github.com/apache/arrow/pull/10142#discussion_r619876276
##########
File path: go/arrow/flight/record_batch_reader.go
##########
@@ -60,15 +68,41 @@ func (d *dataMessageReader) Release() {
if d.msg != nil {
d.msg.Release()
d.msg = nil
+ d.lastAppMetadata = nil
}
}
}
+type Reader struct {
+ *ipc.Reader
+ dmr *dataMessageReader
+}
+
+func (r *Reader) Retain() {
Review comment:
here and below, these are public methods? It would be nice to add some documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org