You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/10 19:47:47 UTC

[GitHub] [beam] apilloud commented on a change in pull request #14698: bugfix in verify_release_build.sh

apilloud commented on a change in pull request #14698:
URL: https://github.com/apache/beam/pull/14698#discussion_r649480644



##########
File path: release/src/main/scripts/verify_release_build.sh
##########
@@ -123,12 +125,14 @@ if [[ ! -z `which hub` ]]; then
   # The version change is needed for Dataflow python batch tests.
   # Without changing to dev version, the dataflow pipeline will fail because of non-existed worker containers.
   # Note that dataflow worker containers should be built after RC has been built.
-  sed -i -e "s/${RELEASE_VER}/${RELEASE_VER}.dev/g" sdks/python/apache_beam/version.py
-  sed -i -e "s/sdk_version=${RELEASE_VER}/sdk_version=${RELEASE_VER}.dev/g" gradle.properties
+  sh "$SCRIPT_DIR"/set_version.sh "$RELEASE_VER"

Review comment:
       This script might also touch `buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy`. Might add a `git add` for that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org