You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/24 08:46:02 UTC
[GitHub] [shardingsphere] soulasuna opened a new issue #10968: Add unit test for shardingsphere-sharding
soulasuna opened a new issue #10968:
URL: https://github.com/apache/shardingsphere/issues/10968
Hi community,
This issue is for #10887.
## Aim
Add unit test for shardingsphere-sharding project to test its public functions.
## Basic Qualifications
- Java
- Maven
- Junit.Test
## Classes
Add unit test for classes to test its public functions.
- [ ] ShardingTableMetaDataBuilder
- [ ] ShardingSQLRewriteContextDecorator
- [ ] ShardingGeneratedKeyInsertValueParameterRewriter
- [ ] ShardingPaginationParameterRewriter
- [ ] ShardingParameterRewriterBuilder
- [ ] GeneratedKeyAssignmentTokenGenerator
- [ ] GeneratedKeyForUseDefaultInsertColumnsTokenGenerator
- [ ] GeneratedKeyInsertColumnTokenGenerator
- [ ] GeneratedKeyInsertValuesTokenGenerator
- [ ] AggregationDistinctTokenGenerator
- [ ] ConstraintTokenGenerator
- [ ] DistinctProjectionPrefixTokenGenerator
- [ ] IndexTokenGenerator
- [ ] OffsetTokenGenerator
- [ ] OrderByTokenGenerator
- [ ] ProjectionsTokenGenerator
- [ ] RowCountTokenGenerator
- [ ] ShardingInsertValuesTokenGenerator
- [ ] TableTokenGenerator
## Examples FYI
- AlgorithmProvidedShardingRuleBuilderTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna commented on issue #10968: Add unit test for shardingsphere-sharding
Posted by GitBox <gi...@apache.org>.
soulasuna commented on issue #10968:
URL: https://github.com/apache/shardingsphere/issues/10968#issuecomment-927278939
@fwhdzh Hi, thank you for your contribution. yes can you fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] fwhdzh commented on issue #10968: Add unit test for shardingsphere-sharding
Posted by GitBox <gi...@apache.org>.
fwhdzh commented on issue #10968:
URL: https://github.com/apache/shardingsphere/issues/10968#issuecomment-935321330
> Hi, so it is still in progress, right?
Yes, it is still in progress. I am sorry for that I am too busy these days to do this work. If it is urgent, please give this task to another person. I could look it the next week if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] fwhdzh commented on issue #10968: Add unit test for shardingsphere-sharding
Posted by GitBox <gi...@apache.org>.
fwhdzh commented on issue #10968:
URL: https://github.com/apache/shardingsphere/issues/10968#issuecomment-900774841
Hello, I want to try this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #10968: Add unit test for shardingsphere-sharding
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10968:
URL: https://github.com/apache/shardingsphere/issues/10968#issuecomment-932896913
Hi, so it is still in progress, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] fwhdzh commented on issue #10968: Add unit test for shardingsphere-sharding
Posted by GitBox <gi...@apache.org>.
fwhdzh commented on issue #10968:
URL: https://github.com/apache/shardingsphere/issues/10968#issuecomment-927133849
Hello. For the last three class. I find that ShardingTableMetaDataBuilder has haved its unit test. And I think ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder may have some problem since it looks like ShardingParameterRewriterBuilder.setUpParameterRewriters() has some "if" statement that will never be executed and ShardingSQLRewriteContextDecorator use ShardingParameterRewriterBuilder in its function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] fwhdzh commented on issue #10968: Add unit test for shardingsphere-sharding
Posted by GitBox <gi...@apache.org>.
fwhdzh commented on issue #10968:
URL: https://github.com/apache/shardingsphere/issues/10968#issuecomment-900774841
Hello, I want to try this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org