[GitHub] [ignite] AMashenkov commented on a change in pull request #9423: IGNITE-15281 New implementation of local statistics collection.

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #9423:
URL: https://github.com/apache/ignite/pull/9423#discussion_r711958880



##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsConfigurationManager.java
##########
@@ -86,35 +82,33 @@
     /** Distributed metastore. */
     private volatile DistributedMetaStorage distrMetaStorage;
 
-    /** Statistics repository.*/
-    private final IgniteStatisticsRepository repo;
-
-    /** Statistic gatherer. */
-    private final StatisticsGatherer gatherer;
+    /** Statistic processor. */
+    private final StatisticsProcessor statProc;
 
     /** */
     private final IgniteThreadPoolExecutor mgmtPool;
 
     /** Logger. */
     private final IgniteLogger log;
 
-    /** Started flag (used to skip updates of the distributed metastorage on start). */
-    private volatile boolean started;
+    /** Last ready topology version if {@code null} - used to skip updates of the distributed metastorage on start. */
+    private volatile AffinityTopologyVersion topVer;
 
     /** Monitor to synchronize changes repository: aggregate after collects and drop statistics. */
     private final Object mux = new Object();
 
-    /** */
+    /** Cluster state processor. */
     private final GridClusterStateProcessor cluster;
 
-    /** */
+    /** Subsctiption processor. */
     private final GridInternalSubscriptionProcessor subscriptionProcessor;
 
-    /** */
+    /** Exchange manager. */
     private final GridCachePartitionExchangeManager exchange;
 
-    /** */
-    private final DistributedMetastorageLifecycleListener distrMetaStoreLsnr = new DistributedMetastorageLifecycleListener() {
+    /** Change statistics configuration listener to update particular object statistics. */
+    private final DistributedMetastorageLifecycleListener distrMetaStoreLsnr =
+        new DistributedMetastorageLifecycleListener() {
         @Override public void onReadyForRead(ReadableDistributedMetaStorage metastorage) {

Review comment:
       Does it make sense to do anything if metastore is readonly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org