You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/12 03:01:12 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on issue #1549: Proposal: Remove `Accumulator::update` and `Accumulator::merge`

liukun4515 commented on issue #1549:
URL: https://github.com/apache/arrow-datafusion/issues/1549#issuecomment-1010582587


   Can we change the default implementation of the accumulator trait to this?
   @alamb 
   
   ```
   pub trait Accumulator{
   
   fn update(&mut self, values: &[ScalarValue]) -> Result<()> {
      // convert the values to &[Arrayref]
      // call the update_batch method
   }
   fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()>;
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org