You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2008/06/04 07:44:45 UTC

[jira] Created: (HARMONY-5861) [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult

[classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult
-------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-5861
                 URL: https://issues.apache.org/jira/browse/HARMONY-5861
             Project: Harmony
          Issue Type: Sub-task
          Components: Classlib
    Affects Versions: 5.0M6
            Reporter: Regis Xu
             Fix For: 5.0M7


collect all code of constructing NamingEnumeration to one place could reduce code duplicate and make it more clearly

And for supporting java.naming.batchsize property, Context class couldn't convert LdapSearchResult to NamingEnumeration
after return of search operations, because there may be new search result items come from server after Context methods return,
such as list and search.

We move the responsibility of converting to LdapSearchResult, so the result set used by LdapNamingEnumeration can grow from
LdapSearchResult directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5861) [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu updated HARMONY-5861:
------------------------------

    Attachment: HARMONY-5861.diff

Would anyone want to try this?

> [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5861
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5861
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>    Affects Versions: 5.0M6
>            Reporter: Regis Xu
>             Fix For: 5.0M7
>
>         Attachments: HARMONY-5861.diff
>
>
> collect all code of constructing NamingEnumeration to one place could reduce code duplicate and make it more clearly
> And for supporting java.naming.batchsize property, Context class couldn't convert LdapSearchResult to NamingEnumeration
> after return of search operations, because there may be new search result items come from server after Context methods return,
> such as list and search.
> We move the responsibility of converting to LdapSearchResult, so the result set used by LdapNamingEnumeration can grow from
> LdapSearchResult directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5861) [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult

Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Qiu resolved HARMONY-5861.
-------------------------------

    Resolution: Fixed

Thanks for the patch. It is applied at r663009.
Please verify it if it works as you expected.

> [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5861
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5861
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>    Affects Versions: 5.0M6
>            Reporter: Regis Xu
>            Assignee: Sean Qiu
>             Fix For: 5.0M7
>
>         Attachments: HARMONY-5861.diff
>
>
> collect all code of constructing NamingEnumeration to one place could reduce code duplicate and make it more clearly
> And for supporting java.naming.batchsize property, Context class couldn't convert LdapSearchResult to NamingEnumeration
> after return of search operations, because there may be new search result items come from server after Context methods return,
> such as list and search.
> We move the responsibility of converting to LdapSearchResult, so the result set used by LdapNamingEnumeration can grow from
> LdapSearchResult directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5861) [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult

Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Qiu reassigned HARMONY-5861:
---------------------------------

    Assignee: Sean Qiu

> [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5861
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5861
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>    Affects Versions: 5.0M6
>            Reporter: Regis Xu
>            Assignee: Sean Qiu
>             Fix For: 5.0M7
>
>         Attachments: HARMONY-5861.diff
>
>
> collect all code of constructing NamingEnumeration to one place could reduce code duplicate and make it more clearly
> And for supporting java.naming.batchsize property, Context class couldn't convert LdapSearchResult to NamingEnumeration
> after return of search operations, because there may be new search result items come from server after Context methods return,
> such as list and search.
> We move the responsibility of converting to LdapSearchResult, so the result set used by LdapNamingEnumeration can grow from
> LdapSearchResult directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5861) [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu closed HARMONY-5861.
-----------------------------


Verified. Thanks Sean!

> [classlib][jndi][ldap] - moving code of constructing NamingEnumeration from Context class to LdapSearchResult
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5861
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5861
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>    Affects Versions: 5.0M6
>            Reporter: Regis Xu
>            Assignee: Sean Qiu
>             Fix For: 5.0M7
>
>         Attachments: HARMONY-5861.diff
>
>
> collect all code of constructing NamingEnumeration to one place could reduce code duplicate and make it more clearly
> And for supporting java.naming.batchsize property, Context class couldn't convert LdapSearchResult to NamingEnumeration
> after return of search operations, because there may be new search result items come from server after Context methods return,
> such as list and search.
> We move the responsibility of converting to LdapSearchResult, so the result set used by LdapNamingEnumeration can grow from
> LdapSearchResult directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.