You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/10/27 18:44:55 UTC
Review Request 39691: Suppress no-op delete log noise during scheduler
startup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
This was causing a long stream of log entries like
```
I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
```
It results from tasks failing the `safeToPrune` predicate.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
Diff: https://reviews.apache.org/r/39691/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 39691: Suppress no-op delete log noise during
scheduler startup.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104205
-----------------------------------------------------------
@ReviewBot retry
Investigating whether this is a flaky check - can't repro on my end.
- Bill Farner
On Oct. 27, 2015, 10:44 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39691/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 10:44 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was causing a long stream of log entries like
> ```
> I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
> ```
>
> It results from tasks failing the `safeToPrune` predicate.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
> src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
>
> Diff: https://reviews.apache.org/r/39691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 39691: Suppress no-op delete log noise during
scheduler startup.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104184
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 27, 2015, 5:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39691/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 5:44 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was causing a long stream of log entries like
> ```
> I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
> ```
>
> It results from tasks failing the `safeToPrune` predicate.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
> src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
>
> Diff: https://reviews.apache.org/r/39691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 39691: Suppress no-op delete log noise during
scheduler startup.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104211
-----------------------------------------------------------
Master (c20346c) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8879244425155517, but must be greater than 0.89
Branch coverage is 0.8152573529411765, but must be greater than 0.835
:analyzeReport FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/GuavaUtils$LifecycleShutdownListener
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 5 mins 55.649 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 27, 2015, 5:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39691/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 5:44 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was causing a long stream of log entries like
> ```
> I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
> ```
>
> It results from tasks failing the `safeToPrune` predicate.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
> src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
>
> Diff: https://reviews.apache.org/r/39691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 39691: Suppress no-op delete log noise during
scheduler startup.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104186
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Oct. 27, 2015, 10:44 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39691/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 10:44 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was causing a long stream of log entries like
> ```
> I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
> ```
>
> It results from tasks failing the `safeToPrune` predicate.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
> src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
>
> Diff: https://reviews.apache.org/r/39691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 39691: Suppress no-op delete log noise during
scheduler startup.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104200
-----------------------------------------------------------
Master (c20346c) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8873871081075495, but must be greater than 0.89
Branch coverage is 0.8138786764705882, but must be greater than 0.835
:analyzeReport FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/GuavaUtils$LifecycleShutdownListener
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 5 mins 18.399 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 27, 2015, 5:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39691/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 5:44 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was causing a long stream of log entries like
> ```
> I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
> ```
>
> It results from tasks failing the `safeToPrune` predicate.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
> src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
>
> Diff: https://reviews.apache.org/r/39691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 39691: Suppress no-op delete log noise during
scheduler startup.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104239
-----------------------------------------------------------
Ship it!
Master (c20346c) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 27, 2015, 10:33 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39691/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 10:33 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was causing a long stream of log entries like
> ```
> I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
> ```
>
> It results from tasks failing the `safeToPrune` predicate.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
> src/test/java/org/apache/aurora/LifecycleShutdownListenerTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
>
> Diff: https://reviews.apache.org/r/39691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 39691: Suppress no-op delete log noise during
scheduler startup.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/
-----------------------------------------------------------
(Updated Oct. 27, 2015, 3:33 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
Added explicit test coverage for LifecycleShutdownListener since its coverage in other tests seems to be non-deterministic.
Repository: aurora
Description
-------
This was causing a long stream of log entries like
```
I1019 02:22:19.776 THREAD1945 org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning inactive tasks []
```
It results from tasks failing the `safeToPrune` predicate.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 4e37070e64c83fb9f1d9caaab1a828a1852e46d9
src/test/java/org/apache/aurora/LifecycleShutdownListenerTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java acd2cd12ac4f1193c7e6148c4a7266f690ecdab2
Diff: https://reviews.apache.org/r/39691/diff/
Testing
-------
Thanks,
Bill Farner