You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2018/02/07 10:16:17 UTC

[GitHub] flink pull request #5421: [FLINK-8573] [client] Add more information for pri...

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/5421

    [FLINK-8573] [client] Add more information for printing JobID for fai…

    ## What is the purpose of the change
    
    *Print JobID for failed jobs*
    
    ## Brief change log
    
    Add jobid information when job failed.
    
    
    ## Verifying this change
    
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no)
      - The S3 file system connector: (no )
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (  no)
      - If yes, how is the feature documented? ( not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-8573

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5421
    
----
commit e27ae3e8186b080450a9551f316b04797858a88f
Author: zhangminglei <zm...@...>
Date:   2018-02-07T10:07:16Z

    [FLINK-8573] [client] Add more information for printing JobID for failed jobs

----


---

[GitHub] flink issue #5421: [FLINK-8573] [client] Add more information for printing J...

Posted by zhangminglei <gi...@git.apache.org>.

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/5421
  
    The CI error does not relevant to this PR. ```BackPressureStatsTrackerITCase``` test failed.


---

[GitHub] flink issue #5421: [FLINK-8573] [client] Add more information for printing J...

Posted by zhangminglei <gi...@git.apache.org>.

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/5421
  
    Sup ?


---

[GitHub] flink pull request #5421: [FLINK-8573] [client] Add more information for pri...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5421


---

[GitHub] flink issue #5421: [FLINK-8573] [client] Add more information for printing J...

Posted by azagrebin <gi...@git.apache.org>.

Github user azagrebin commented on the issue:

    https://github.com/apache/flink/pull/5421
  
    @zhangminglei 
    
    what do you think about creation one more `ProgramInvocationException` overloaded constructor with JobId as parameter? It could always append to the message like `MESSAGE + (Job Id is ...)` and be used wherever `ProgramInvocationException` is instantiated and JobId is known.
    
    Can you please rebase on the current master to repeat the CI test?


---