You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "sivabalan narayanan (Jira)" <ji...@apache.org> on 2023/03/30 02:10:00 UTC
[jira] [Updated] (HUDI-5231) Address checkstyle warnings while building hudi
[ https://issues.apache.org/jira/browse/HUDI-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
sivabalan narayanan updated HUDI-5231:
--------------------------------------
Fix Version/s: 0.12.3
> Address checkstyle warnings while building hudi
> -----------------------------------------------
>
> Key: HUDI-5231
> URL: https://issues.apache.org/jira/browse/HUDI-5231
> Project: Apache Hudi
> Issue Type: Improvement
> Components: dev-experience
> Reporter: sivabalan narayanan
> Assignee: Jonathan Vexler
> Priority: Critical
> Labels: pull-request-available
> Fix For: 0.13.0, 0.12.3
>
>
> As of now, we see lot of checkstyle warnings while building hudi. We need to take a look to see how exactly we can fix this.
> * Take a stab at fixing as much as possible.
> * If we couldn't get it to a controllable number, suppress the checkstyle warnings.
>
> excerpt logs
> {code:java}
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestGcsEventsHoodieIncrSource.java:46: 'org.apache.log4j.LogManager' should be separated from previous imports. [ImportOrder]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestGcsEventsHoodieIncrSource.java:74: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestGcsEventsHoodieIncrSource.java:271: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestInputBatch.java:33: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJsonKafkaSourcePostProcessor.java:22: Import org.apache.hudi.common.config.TypedProperties appears after other imports that it should precede [ImportOrder]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJsonKafkaSourcePostProcessor.java:61: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJsonKafkaSourcePostProcessor.java:315: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestCheckpointUtils.java:24: Import org.apache.hudi.utilities.sources.helpers.KafkaOffsetGen.CheckpointUtils appears after other imports that it should precede [ImportOrder]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestS3EventsMetaSelector.java:56: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestProtoConversionUtil.java:47: Import com.google.protobuf.util.Timestamps appears after other imports that it should precede [ImportOrder]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestProtoConversionUtil.java:72: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestDFSPathSelectorCommonMethods.java:46: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestCloudObjectsSelector.java:57: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestDatePartitionPathSelector.java:49: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/debezium/TestMysqlDebeziumSource.java:31: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/debezium/TestPostgresDebeziumSource.java:31: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/debezium/TestAbstractDebeziumSource.java:58: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/checkpointing/TestKafkaConnectHdfsProvider.java:36: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java:54: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieRepairTool.java:69: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/transform/TestSqlFileBasedTransformer.java:45: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/transform/TestChainedTransformer.java:30: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/transform/TestSqlQueryBasedTransformer.java:35: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/transform/TestFlatteningTransformer.java:29: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotCopier.java:43: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java:68: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java:126: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java:159: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java:217: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java:233: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java:247: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestJdbcbasedSchemaProvider.java:42: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHDFSParquetImporter.java:61: Missing a Javadoc comment. [JavadocType]
> [INFO] /Users/nsb/Documents/personal/projects/nov26/hudi/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestAWSDatabaseMigrationServiceSource.java:40: Missing a Javadoc comment. [JavadocType] {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)