You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Janus Chow (Jira)" <ji...@apache.org> on 2021/01/15 16:19:00 UTC
[jira] [Commented] (HDDS-2195) Apply spotbugs check to test code
[ https://issues.apache.org/jira/browse/HDDS-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266165#comment-17266165 ]
Janus Chow commented on HDDS-2195:
----------------------------------
[~adoroszlai], Have raised the PR, could you help to check?
The handling of the bugs reported by spotbugs is as follows:
|project|module|Package/Class|Handling|
|hdds|common|org.apache.hadoop.hdds.cli.GenericCli|Add to spotbugs-exclude.xml|
|hdds|common|org.apache.hadoop.ozone.common.ChecksumByteBuffer$CrcIntTable|Add to spotbugs-exclude.xml|
|hdds|container-service|org.apache.hadoop.ozone.container.common.volume.AbstractFuture|remove "boolean unused"|
|hdds|container-service|org.apache.hadoop.ozone.container.common.volume.AbstractFuture|Add to spotbugs-exclude.xml|
|hdds|container-service|org.apache.hadoop.ozone.container.common.volume.AbstractFuture|change "\|" to "\|\|"|
|hdds|interface-admin|org\.apache\.hadoop\.hdds\.protocol\.proto\.StorageContainerLocationProtocolProtos\$.*|Add to spotbugs-exclude.xml|
|hdds|interface-client|org\.apache\.hadoop\.hdds\.protocol\.datanode\.proto\.ContainerProtos\$.*|Add to spotbugs-exclude.xml|
|hdds|interface-client|org\.apache\.hadoop\.hdds\.protocol\.proto\.HddsProtos\$.*|Add to spotbugs-exclude.xml|
|hdds|interface-server|org\.apache\.hadoop\.hdds\.protocol\.proto\.SCMSecurityProtocolProtos\$.*|Add to spotbugs-exclude.xml|
|hdds|interface-server|org\.apache\.hadoop\.hdds\.protocol\.proto\.ScmBlockLocationProtocolProtos\$.*|Add to spotbugs-exclude.xml|
|hdds|interface-server|org\.apache\.hadoop\.hdds\.protocol\.proto\.StorageContainerDatanodeProtocolProtos\$.*|Add to spotbugs-exclude.xml|
|ozone|csi|csi\.v1\.Csi\$.*|Add to spotbugs-exclude.xml|
|ozone|interface-client|org\.apache\.hadoop\.ozone\.protocol\.proto\.OzoneManagerProtocolProtos\$.*|Add to spotbugs-exclude.xml|
|ozone|interface-client|org\.apache\.hadoop\.ozone\.security\.proto\.SecurityProtos\$.*|Add to spotbugs-exclude.xml|
|ozone|interface-storage|org\.apache\.hadoop\.ozone\.storage\.proto\.OzoneManagerStorageProtos\$.*|Add to spotbugs-exclude.xml|
|ozone|recon|org\.hadoop\.ozone\.recon\.schema.*|Add to spotbugs-exclude.xml|
|ozone|tools|org\.apache\.hadoop\.ozone\.genesis\.generated\.Bench.*|Add to spotbugs-exclude.xml|
> Apply spotbugs check to test code
> ---------------------------------
>
> Key: HDDS-2195
> URL: https://issues.apache.org/jira/browse/HDDS-2195
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Janus Chow
> Priority: Major
> Labels: newbie, pull-request-available
>
> The goal of this task is to [enable Spotbugs to run on test code|https://spotbugs.github.io/spotbugs-maven-plugin/spotbugs-mojo.html#includeTests], and fix all issues it reports (both to improve code and to avoid breaking CI).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org