You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2023/09/01 10:46:17 UTC
[GitHub] [solr] epugh opened a new pull request, #1880: fix not being able to stop a solr by port number
epugh opened a new pull request, #1880:
URL: https://github.com/apache/solr/pull/1880
https://issues.apache.org/jira/browse/SOLR-16956
# Description
In doing some other testing, I noticed that `bin/solr stop -p 7574` didn't work, I get back the error message:
```
Found 2 Solr nodes running! Must either specify a port using -p or -all to stop all Solr nodes on this host.
```
# Solution
Set the PROVIDED_SOLR_PORT to the SOLR_PORT.
# Tests
extended bats tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1880: fix not being able to stop a solr by port number
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1702552060
@HoustonPutman didn't you recently look at some port stuff? COuld you review this bug fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #1880: SOLR-16956: fix not being able to stop a solr by port number
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1704992451
> ... it suggests running shellcheck. That isn't actually something I've ever done, and I wonder if it's the type of thing that should be run as part of precommit ...
I've not yet run shellcheck either but running as part of precommit too sounds like a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1880: SOLR-16956: fix not being able to stop a solr by port number
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1703815652
Thanks @cpoerschke for the feedback... one thing I noticed in the BATS docs is that it suggests running shellcheck. That isn't actually something I've ever done, and I wonder if it's the type of thing that should be run as part of precommit to make sure we keep both our bin/solr script and the various bats tests following best practices?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1880: SOLR-16956: fix not being able to stop a solr by port number
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1880:
URL: https://github.com/apache/solr/pull/1880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #1880: fix not being able to stop a solr by port number
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on code in PR #1880:
URL: https://github.com/apache/solr/pull/1880#discussion_r1313306240
##########
solr/bin/solr:
##########
@@ -1301,6 +1301,7 @@ if [ $# -gt 0 ]; then
exit 1
fi
SOLR_PORT="$2"
+ PROVIDED_SOLR_PORT=SOLR_PORT
Review Comment:
Did you mean `${SOLR_PORT}` here instead?
```suggestion
PROVIDED_SOLR_PORT="${SOLR_PORT}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1880: fix not being able to stop a solr by port number
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1702561090
I tested on Branch_9x, and this issue is only on Main.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1880: SOLR-16956: fix not being able to stop a solr by port number
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1706338398
I am going to merge this without an entry in Changes.txt since it's a bugfix in 10, that doesn't appear to exist in 9...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org