You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "vikrambohra (via GitHub)" <gi...@apache.org> on 2023/05/25 21:16:15 UTC
[GitHub] [gobblin] vikrambohra opened a new pull request, #3698: [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics
vikrambohra opened a new pull request, #3698:
URL: https://github.com/apache/gobblin/pull/3698
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1805
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Currently, Audit check is done for [currentWatermark, currentWatermark +1hour] window for quiet topics. However when the audit check for this window fails (due to an upstream bug in audit), the watermark never progress as the currentWatermark is never updated. To avoid this we keep progressing the watermark by checking the window [currentHour -1, currentHour] window
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Updated unit test to reflect this change
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 merged pull request #3698: [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics
Posted by "ZihanLi58 (via GitHub)" <gi...@apache.org>.
ZihanLi58 merged PR #3698:
URL: https://github.com/apache/gobblin/pull/3698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3698: [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3698:
URL: https://github.com/apache/gobblin/pull/3698#issuecomment-1563664347
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3698](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a7d398d) into [master](https://app.codecov.io/gh/apache/gobblin/commit/158d6fff546ee28ad7b542bfe78e5263af8843c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (158d6ff) will **decrease** coverage by `4.68%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3698 +/- ##
============================================
- Coverage 49.45% 44.78% -4.68%
+ Complexity 9309 2095 -7214
============================================
Files 1756 411 -1345
Lines 68468 17726 -50742
Branches 7809 2161 -5648
============================================
- Hits 33862 7938 -25924
+ Misses 31466 8927 -22539
+ Partials 3140 861 -2279
```
| [Impacted Files](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh) | `72.31% <100.00%> (-0.05%)` | :arrow_down: |
... and [1349 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3698/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org