You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/31 19:46:59 UTC

[GitHub] [incubator-superset] DiggidyDave commented on issue #7952: [security] Adding docstrings and type hints

DiggidyDave commented on issue #7952: [security] Adding docstrings and type hints
URL: https://github.com/apache/incubator-superset/pull/7952#issuecomment-516994003
 
 
   > I believe there would be merit in aligning on one mechanism for defining SQL tables throughout Superset ... A dataclass class may be a viable route.
   
   👍 agreed! if something is important enough that folks have invented 3 ways of doing it, it probably should have a first-class type :-) 
   
   Thanks for doing all of this work

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org