You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/23 20:32:20 UTC
[GitHub] [geode] kirklund commented on a change in pull request #5648: GEODE-5782: Try to improve memory reporting stats for Windows
kirklund commented on a change in pull request #5648:
URL: https://github.com/apache/geode/pull/5648#discussion_r511141909
##########
File path: geode-core/src/integrationTest/java/org/apache/geode/distributed/LauncherMemberMXBeanIntegrationTest.java
##########
@@ -227,6 +227,8 @@ public void showJVMMetrics_returnsOJVMMetricsType()
if (cdsValue.equals(osMetricValue)) {
break;
}
+ System.gc();
+ System.runFinalization();
Review comment:
I'm really reluctant to add `gc()` or `runFinalization()`. Why do you think these will fix flakiness in this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org