You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/09/13 20:52:15 UTC
Review Request 62308: Added the description for the isolators section.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62308/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and James Peach.
Repository: mesos
Description
-------
Added the description for the isolators section.
Diffs
-----
docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
Diff: https://reviews.apache.org/r/62308/diff/1/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 62308: Added the description for the isolators
section.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62308/#review185434
-----------------------------------------------------------
docs/mesos-containerizer.md
Lines 18 (patched)
<https://reviews.apache.org/r/62308/#comment261749>
I think that we could phrase this a little more clearly. Maybe:
Isolators are components that each define an aspect of how a tasks execution environment (or container) is constructes. Isolators can control how containers are isolated from each other, how task resource limits are enforced, how networking is configured, how security policies are applied.
Since the isolator interface is modularized, operators can write modules that implement custom isolators.
docs/mesos-containerizer.md
Lines 24 (patched)
<https://reviews.apache.org/r/62308/#comment261742>
"Mesos supports the following built-in isolators:"
- James Peach
On Sept. 13, 2017, 8:52 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62308/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 8:52 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the description for the isolators section.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62308/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62308: Added the description for the isolators
section.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62308/#review185345
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62295', '62296', '62297', '62298', '62299', '62300', '62301', '62302', '62303', '62304', '62305', '62306', '62307', '62308']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62308
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62308/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (266 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (225 ms)
[----------] 30 tests from ContentType/SchedulerTest (24840 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (880 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1086 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2049 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (136 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (156 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (330 ms total)
[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (355203 ms total)
[ PASSED ] 626 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 174 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62308/logs/mesos-tests-stderr.log):
```
I0913 22:49:43.881287 14368 master.cpp:8418] Removing framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 (default)
I0913 22:49:43.881287 14368 master.cpp:3267] Deactivating framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 (default)
I0913 22:49:43.882287 14892 hierarchical.cpp:412] Deactivated framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000
I0913 22:49:43.882287 6672 slave.cpp:3235] Shutting down framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000
I0913 22:49:43.882287 14368 master.cpp:8993] Updating the state of task 7c9dd94b-c5c3-4724-ae89-57818dc91cd7 of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0913 22:49:43.914865 6672 slave.cpp:5731] Shutting down executor 'default' of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 (via HTTP)
I0913 22:49:43.918866 14368 master.cpp:9087] Removing task 7c9dd94b-c5c3-4724-ae89-57818dc91cd7 with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 on agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 22:49:43.940208 14368 master.cpp:9116] Removing executor 'default' with resources [] of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 on agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 22:49:43.944226 15196 hierarchical.cpp:355] Removed framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000
E0913 22:49:43.945227 7064 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I0913 22:49:43.946226 8788 scheduler.cpp:444] Re-detecting master
I0913 22:49:43.952226 11728 scheduler.cpp:470] New master detected at master@10.3.1.7:62249
I0913 22:49:43.960227 7064 slave.cpp:5407] Executor 'default' of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 exited with status 0
I0913 22:49:43.967227 7064 slave.cpp:5511] Cleaning up executor 'default' of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 (via HTTP)
W0913 22:49:43.970232 14348 master.cpp:7021] Ignoring unknown exited executor 'default' of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 on agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 22:49:43.981227 8788 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\otuSiJ\slaves\a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0\frameworks\a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000\executors\default\runs\07d520e6-65bf-4f62-8e3e-8448bf761912' for gc 6.99998864319407days in the future
I0913 22:49:43.983227 6672 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\otuSiJ\slaves\a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0\frameworks\a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000\executors\default' for gc 6.99998862004741days in the future
I0913 22:49:43.983227 7064 slave.cpp:5607] Cleaning up framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000
I0913 22:49:43.995227 14368 status_update_manager.cpp:285] Closing status update streams for framework a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000
I0913 22:49:43.995227 15196 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\otuSiJ\slaves\a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0\frameworks\a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000' for gc 6.99998848115852days in the future
I0913 22:49:43.996230 7064 slave.cpp:861] Agent terminating
I0913 22:49:43.997229 11728 master.cpp:1321] Agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0913 22:49:43.997229 11728 master.cpp:3304] Disconnecting agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 22:49:43.997229 11728 master.cpp:3323] Deactivating agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 22:49:44.009230 8788 hierarchical.cpp:690] Agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 deactivated
I0913 22:49:44.033234 11728 master.cpp:1163] Master terminating
I0913 22:49:44.040292 8788 hierarchical.cpp:626] Removed agent a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0
W0913 22:49:44.048233 13736 master.hpp:2761] Failed to close HTTP pipe for a559f1e1-31d8-4cac-a7b3-5f27e313087b-0000 (default)
I0913 22:49:44.733304 15192 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Sept. 13, 2017, 8:52 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62308/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 8:52 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the description for the isolators section.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62308/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62308: Added the description for the isolators
section.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62308/#review185601
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Sept. 15, 2017, 6:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62308/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 6:49 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the description for the isolators section.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62308/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62308: Added the description for the isolators
section.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62308/
-----------------------------------------------------------
(Updated Sept. 16, 2017, 1:49 a.m.)
Review request for mesos, Gilbert Song and James Peach.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
Added the description for the isolators section.
Diffs (updated)
-----
docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
Diff: https://reviews.apache.org/r/62308/diff/2/
Changes: https://reviews.apache.org/r/62308/diff/1-2/
Testing
-------
Thanks,
Jie Yu