You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by Dominik Riemer <ri...@apache.org> on 2020/05/27 17:16:27 UTC
Migrating the pipeline editor to Angular
Hi all,
I’ve created an issue [1] to migrate the pipeline editor module in the UI from AngularJS to Angular.
A little background:
We are currently running AngularJS and Angular in parallel and have started to migrate old AngularJS modules component-by-component. The only modules left that are still implemented in AngularJS are the pipeline editor, the pipeline overview and the pipeline element installation modules. I’d personally prefer to abandon AngularJS sooner than later as it complicates the development of some UI-wide features (e.g., better user and access management) and hinders reuse of components. So I think I will start migrating the pipeline editor now and maybe we can get this finished before the next release.
So as this implies a rather major refactoring anyways, I’m interested if you see any things in the UI of the pipeline editor that could be improved or things you are missing?
Any thoughts and ideas are welcome 😊
Dominik
[1] https://issues.apache.org/jira/browse/STREAMPIPES-145
Re: RE: Migrating the pipeline editor to Angular
Posted by Dominik Riemer <ri...@apache.org>.
Hi all,
just to give you a quick status update - I'm almost finished with migrating the pipeline editor.
There are still a few things missing (form validation and migration of some static property renderers, e.g., for code input), but I plan to have this finished soon.
Afterwards, I'll directly start to migrate the pipeline overview/pipeline details view, as both views share some components with the pipeline editor.
Dominik
On 2020/06/02 19:28:00, "Dominik Riemer" <ri...@apache.org> wrote:
> Hi Grainier,
>
> that's totally correct - I knew I had this in mind when implementing Alternatives but obviously conditional fields are not supported right now.
> I'll implement this as soon as the editor is migrated!
>
> Dominik
>
> -----Original Message-----
> From: Grainier Perera <gr...@apache.org>
> Sent: Monday, June 1, 2020 3:07 PM
> To: dev@streampipes.apache.org
> Subject: Re: Migrating the pipeline editor to Angular
>
> Hi Dominik,
>
> Thank you for considering those improvements and creating an issue to track them. When it comes to conditional fields, I couldn't find a way to make following an AlternativeStaticProperty. For example, I need the user to have a toggle to select whether to enable group-by or not and only if he/she chose to have group-by, then show the field selection. I couldn't find it, but is there a way to achieve that?
>
> .requiredStream(StreamRequirementsBuilder.create()
> >
> > .requiredPropertyWithUnaryMapping(EpRequirements.anyProperty(),Labels.
> > withId(GROUPING_FIELD),
> > PropertyScope.NONE)
> > .build())
>
>
> Grainier Perera.
>
>
> On Mon, 1 Jun 2020 at 02:53, Dominik Riemer <ri...@apache.org> wrote:
>
> > Ok, I've just seen that you already used this in the rate limit
> > component
> > 😉
> >
> > So just ignore what I wrote in the second paragraph 😉
> > Dominik
> >
> > -----Original Message-----
> > From: Dominik Riemer <ri...@apache.org>
> > Sent: Sunday, May 31, 2020 11:19 PM
> > To: dev@streampipes.apache.org
> > Subject: RE: Migrating the pipeline editor to Angular
> >
> > Hi Grainier,
> >
> > yes, that would be nice to have and one of the things that will be
> > easier to implement after migration.
> > I created a JIRA for tracking ideas for that kind of improvements,
> > feel free to add more if you have any ideas!
> > https://issues.apache.org/jira/browse/STREAMPIPES-150
> >
> > There is currently a feature to create simple conditional fields
> > called
> > AlternativeStaticProperty:
> >
> > https://github.com/apache/incubator-streampipes-examples/blob/dev/stre
> > ampipes-pipeline-elements-examples-processors-jvm/src/main/java/org/ap
> > ache/streampipes/pe/examples/jvm/staticproperty/StaticPropertyAlternat
> > ivesController.java However, the API is currently quite verbose and
> > I'd also like to simplify this.
> >
> > Dominik
> >
> > -----Original Message-----
> > From: Grainier Perera <gr...@apache.org>
> > Sent: Thursday, May 28, 2020 4:16 PM
> > To: dev@streampipes.apache.org
> > Subject: Re: Migrating the pipeline editor to Angular
> >
> > Hi Dominik,
> >
> > This is awesome. Also, I'd like to see some optional fields and
> > conditional fields (i.e different input fields depending on a toggle)
> > with user inputs to PEs. I don't know whether this is the correct
> > thread to ask, but I feel like it's nice to have.
> >
> > Grainier Perera.
> >
> >
> > On Wed, 27 May 2020 at 22:46, Dominik Riemer <ri...@apache.org> wrote:
> >
> > > Hi all,
> > >
> > >
> > >
> > > I’ve created an issue [1] to migrate the pipeline editor module in
> > > the UI from AngularJS to Angular.
> > >
> > >
> > >
> > > A little background:
> > >
> > > We are currently running AngularJS and Angular in parallel and have
> > > started to migrate old AngularJS modules component-by-component. The
> > > only modules left that are still implemented in AngularJS are the
> > > pipeline editor, the pipeline overview and the pipeline element
> > > installation modules. I’d personally prefer to abandon AngularJS
> > > sooner than later as it complicates the development of some UI-wide
> > > features (e.g., better user and access management) and hinders reuse
> > > of components. So I think I will start migrating the pipeline editor
> > > now and maybe we can get this finished before the next release.
> > >
> > >
> > >
> > > So as this implies a rather major refactoring anyways, I’m
> > > interested if you see any things in the UI of the pipeline editor
> > > that could be improved or things you are missing?
> > >
> > > Any thoughts and ideas are welcome 😊
> > >
> > >
> > >
> > > Dominik
> > >
> > >
> > >
> > > [1] https://issues.apache.org/jira/browse/STREAMPIPES-145
> > >
> > >
> >
> >
> >
>
>
RE: Migrating the pipeline editor to Angular
Posted by Dominik Riemer <ri...@apache.org>.
Hi Grainier,
that's totally correct - I knew I had this in mind when implementing Alternatives but obviously conditional fields are not supported right now.
I'll implement this as soon as the editor is migrated!
Dominik
-----Original Message-----
From: Grainier Perera <gr...@apache.org>
Sent: Monday, June 1, 2020 3:07 PM
To: dev@streampipes.apache.org
Subject: Re: Migrating the pipeline editor to Angular
Hi Dominik,
Thank you for considering those improvements and creating an issue to track them. When it comes to conditional fields, I couldn't find a way to make following an AlternativeStaticProperty. For example, I need the user to have a toggle to select whether to enable group-by or not and only if he/she chose to have group-by, then show the field selection. I couldn't find it, but is there a way to achieve that?
.requiredStream(StreamRequirementsBuilder.create()
>
> .requiredPropertyWithUnaryMapping(EpRequirements.anyProperty(),Labels.
> withId(GROUPING_FIELD),
> PropertyScope.NONE)
> .build())
Grainier Perera.
On Mon, 1 Jun 2020 at 02:53, Dominik Riemer <ri...@apache.org> wrote:
> Ok, I've just seen that you already used this in the rate limit
> component
> 😉
>
> So just ignore what I wrote in the second paragraph 😉
> Dominik
>
> -----Original Message-----
> From: Dominik Riemer <ri...@apache.org>
> Sent: Sunday, May 31, 2020 11:19 PM
> To: dev@streampipes.apache.org
> Subject: RE: Migrating the pipeline editor to Angular
>
> Hi Grainier,
>
> yes, that would be nice to have and one of the things that will be
> easier to implement after migration.
> I created a JIRA for tracking ideas for that kind of improvements,
> feel free to add more if you have any ideas!
> https://issues.apache.org/jira/browse/STREAMPIPES-150
>
> There is currently a feature to create simple conditional fields
> called
> AlternativeStaticProperty:
>
> https://github.com/apache/incubator-streampipes-examples/blob/dev/stre
> ampipes-pipeline-elements-examples-processors-jvm/src/main/java/org/ap
> ache/streampipes/pe/examples/jvm/staticproperty/StaticPropertyAlternat
> ivesController.java However, the API is currently quite verbose and
> I'd also like to simplify this.
>
> Dominik
>
> -----Original Message-----
> From: Grainier Perera <gr...@apache.org>
> Sent: Thursday, May 28, 2020 4:16 PM
> To: dev@streampipes.apache.org
> Subject: Re: Migrating the pipeline editor to Angular
>
> Hi Dominik,
>
> This is awesome. Also, I'd like to see some optional fields and
> conditional fields (i.e different input fields depending on a toggle)
> with user inputs to PEs. I don't know whether this is the correct
> thread to ask, but I feel like it's nice to have.
>
> Grainier Perera.
>
>
> On Wed, 27 May 2020 at 22:46, Dominik Riemer <ri...@apache.org> wrote:
>
> > Hi all,
> >
> >
> >
> > I’ve created an issue [1] to migrate the pipeline editor module in
> > the UI from AngularJS to Angular.
> >
> >
> >
> > A little background:
> >
> > We are currently running AngularJS and Angular in parallel and have
> > started to migrate old AngularJS modules component-by-component. The
> > only modules left that are still implemented in AngularJS are the
> > pipeline editor, the pipeline overview and the pipeline element
> > installation modules. I’d personally prefer to abandon AngularJS
> > sooner than later as it complicates the development of some UI-wide
> > features (e.g., better user and access management) and hinders reuse
> > of components. So I think I will start migrating the pipeline editor
> > now and maybe we can get this finished before the next release.
> >
> >
> >
> > So as this implies a rather major refactoring anyways, I’m
> > interested if you see any things in the UI of the pipeline editor
> > that could be improved or things you are missing?
> >
> > Any thoughts and ideas are welcome 😊
> >
> >
> >
> > Dominik
> >
> >
> >
> > [1] https://issues.apache.org/jira/browse/STREAMPIPES-145
> >
> >
>
>
>
Re: Migrating the pipeline editor to Angular
Posted by Grainier Perera <gr...@apache.org>.
Hi Dominik,
Thank you for considering those improvements and creating an issue to track
them. When it comes to conditional fields, I couldn't find a way to make
following an AlternativeStaticProperty. For example, I need the user to
have a toggle to select whether to enable group-by or not and only if
he/she chose to have group-by, then show the field selection. I couldn't
find it, but is there a way to achieve that?
.requiredStream(StreamRequirementsBuilder.create()
> .requiredPropertyWithUnaryMapping(EpRequirements.anyProperty(),Labels.withId(GROUPING_FIELD),
> PropertyScope.NONE)
> .build())
Grainier Perera.
On Mon, 1 Jun 2020 at 02:53, Dominik Riemer <ri...@apache.org> wrote:
> Ok, I've just seen that you already used this in the rate limit component
> 😉
>
> So just ignore what I wrote in the second paragraph 😉
> Dominik
>
> -----Original Message-----
> From: Dominik Riemer <ri...@apache.org>
> Sent: Sunday, May 31, 2020 11:19 PM
> To: dev@streampipes.apache.org
> Subject: RE: Migrating the pipeline editor to Angular
>
> Hi Grainier,
>
> yes, that would be nice to have and one of the things that will be easier
> to implement after migration.
> I created a JIRA for tracking ideas for that kind of improvements, feel
> free to add more if you have any ideas!
> https://issues.apache.org/jira/browse/STREAMPIPES-150
>
> There is currently a feature to create simple conditional fields called
> AlternativeStaticProperty:
>
> https://github.com/apache/incubator-streampipes-examples/blob/dev/streampipes-pipeline-elements-examples-processors-jvm/src/main/java/org/apache/streampipes/pe/examples/jvm/staticproperty/StaticPropertyAlternativesController.java
> However, the API is currently quite verbose and I'd also like to simplify
> this.
>
> Dominik
>
> -----Original Message-----
> From: Grainier Perera <gr...@apache.org>
> Sent: Thursday, May 28, 2020 4:16 PM
> To: dev@streampipes.apache.org
> Subject: Re: Migrating the pipeline editor to Angular
>
> Hi Dominik,
>
> This is awesome. Also, I'd like to see some optional fields and
> conditional fields (i.e different input fields depending on a toggle) with
> user inputs to PEs. I don't know whether this is the correct thread to ask,
> but I feel like it's nice to have.
>
> Grainier Perera.
>
>
> On Wed, 27 May 2020 at 22:46, Dominik Riemer <ri...@apache.org> wrote:
>
> > Hi all,
> >
> >
> >
> > I’ve created an issue [1] to migrate the pipeline editor module in the
> > UI from AngularJS to Angular.
> >
> >
> >
> > A little background:
> >
> > We are currently running AngularJS and Angular in parallel and have
> > started to migrate old AngularJS modules component-by-component. The
> > only modules left that are still implemented in AngularJS are the
> > pipeline editor, the pipeline overview and the pipeline element
> > installation modules. I’d personally prefer to abandon AngularJS
> > sooner than later as it complicates the development of some UI-wide
> > features (e.g., better user and access management) and hinders reuse
> > of components. So I think I will start migrating the pipeline editor
> > now and maybe we can get this finished before the next release.
> >
> >
> >
> > So as this implies a rather major refactoring anyways, I’m interested
> > if you see any things in the UI of the pipeline editor that could be
> > improved or things you are missing?
> >
> > Any thoughts and ideas are welcome 😊
> >
> >
> >
> > Dominik
> >
> >
> >
> > [1] https://issues.apache.org/jira/browse/STREAMPIPES-145
> >
> >
>
>
>
RE: Migrating the pipeline editor to Angular
Posted by Dominik Riemer <ri...@apache.org>.
Ok, I've just seen that you already used this in the rate limit component 😉
So just ignore what I wrote in the second paragraph 😉
Dominik
-----Original Message-----
From: Dominik Riemer <ri...@apache.org>
Sent: Sunday, May 31, 2020 11:19 PM
To: dev@streampipes.apache.org
Subject: RE: Migrating the pipeline editor to Angular
Hi Grainier,
yes, that would be nice to have and one of the things that will be easier to implement after migration.
I created a JIRA for tracking ideas for that kind of improvements, feel free to add more if you have any ideas!
https://issues.apache.org/jira/browse/STREAMPIPES-150
There is currently a feature to create simple conditional fields called AlternativeStaticProperty:
https://github.com/apache/incubator-streampipes-examples/blob/dev/streampipes-pipeline-elements-examples-processors-jvm/src/main/java/org/apache/streampipes/pe/examples/jvm/staticproperty/StaticPropertyAlternativesController.java
However, the API is currently quite verbose and I'd also like to simplify this.
Dominik
-----Original Message-----
From: Grainier Perera <gr...@apache.org>
Sent: Thursday, May 28, 2020 4:16 PM
To: dev@streampipes.apache.org
Subject: Re: Migrating the pipeline editor to Angular
Hi Dominik,
This is awesome. Also, I'd like to see some optional fields and conditional fields (i.e different input fields depending on a toggle) with user inputs to PEs. I don't know whether this is the correct thread to ask, but I feel like it's nice to have.
Grainier Perera.
On Wed, 27 May 2020 at 22:46, Dominik Riemer <ri...@apache.org> wrote:
> Hi all,
>
>
>
> I’ve created an issue [1] to migrate the pipeline editor module in the
> UI from AngularJS to Angular.
>
>
>
> A little background:
>
> We are currently running AngularJS and Angular in parallel and have
> started to migrate old AngularJS modules component-by-component. The
> only modules left that are still implemented in AngularJS are the
> pipeline editor, the pipeline overview and the pipeline element
> installation modules. I’d personally prefer to abandon AngularJS
> sooner than later as it complicates the development of some UI-wide
> features (e.g., better user and access management) and hinders reuse
> of components. So I think I will start migrating the pipeline editor
> now and maybe we can get this finished before the next release.
>
>
>
> So as this implies a rather major refactoring anyways, I’m interested
> if you see any things in the UI of the pipeline editor that could be
> improved or things you are missing?
>
> Any thoughts and ideas are welcome 😊
>
>
>
> Dominik
>
>
>
> [1] https://issues.apache.org/jira/browse/STREAMPIPES-145
>
>
RE: Migrating the pipeline editor to Angular
Posted by Dominik Riemer <ri...@apache.org>.
Hi Grainier,
yes, that would be nice to have and one of the things that will be easier to implement after migration.
I created a JIRA for tracking ideas for that kind of improvements, feel free to add more if you have any ideas!
https://issues.apache.org/jira/browse/STREAMPIPES-150
There is currently a feature to create simple conditional fields called AlternativeStaticProperty:
https://github.com/apache/incubator-streampipes-examples/blob/dev/streampipes-pipeline-elements-examples-processors-jvm/src/main/java/org/apache/streampipes/pe/examples/jvm/staticproperty/StaticPropertyAlternativesController.java
However, the API is currently quite verbose and I'd also like to simplify this.
Dominik
-----Original Message-----
From: Grainier Perera <gr...@apache.org>
Sent: Thursday, May 28, 2020 4:16 PM
To: dev@streampipes.apache.org
Subject: Re: Migrating the pipeline editor to Angular
Hi Dominik,
This is awesome. Also, I'd like to see some optional fields and conditional fields (i.e different input fields depending on a toggle) with user inputs to PEs. I don't know whether this is the correct thread to ask, but I feel like it's nice to have.
Grainier Perera.
On Wed, 27 May 2020 at 22:46, Dominik Riemer <ri...@apache.org> wrote:
> Hi all,
>
>
>
> I’ve created an issue [1] to migrate the pipeline editor module in the
> UI from AngularJS to Angular.
>
>
>
> A little background:
>
> We are currently running AngularJS and Angular in parallel and have
> started to migrate old AngularJS modules component-by-component. The
> only modules left that are still implemented in AngularJS are the
> pipeline editor, the pipeline overview and the pipeline element
> installation modules. I’d personally prefer to abandon AngularJS
> sooner than later as it complicates the development of some UI-wide
> features (e.g., better user and access management) and hinders reuse
> of components. So I think I will start migrating the pipeline editor
> now and maybe we can get this finished before the next release.
>
>
>
> So as this implies a rather major refactoring anyways, I’m interested
> if you see any things in the UI of the pipeline editor that could be
> improved or things you are missing?
>
> Any thoughts and ideas are welcome 😊
>
>
>
> Dominik
>
>
>
> [1] https://issues.apache.org/jira/browse/STREAMPIPES-145
>
>
Re: Migrating the pipeline editor to Angular
Posted by Grainier Perera <gr...@apache.org>.
Hi Dominik,
This is awesome. Also, I'd like to see some optional fields and conditional
fields (i.e different input fields depending on a toggle) with user inputs
to PEs. I don't know whether this is the correct thread to ask, but I feel
like it's nice to have.
Grainier Perera.
On Wed, 27 May 2020 at 22:46, Dominik Riemer <ri...@apache.org> wrote:
> Hi all,
>
>
>
> I’ve created an issue [1] to migrate the pipeline editor module in the UI
> from AngularJS to Angular.
>
>
>
> A little background:
>
> We are currently running AngularJS and Angular in parallel and have
> started to migrate old AngularJS modules component-by-component. The only
> modules left that are still implemented in AngularJS are the pipeline
> editor, the pipeline overview and the pipeline element installation
> modules. I’d personally prefer to abandon AngularJS sooner than later as it
> complicates the development of some UI-wide features (e.g., better user and
> access management) and hinders reuse of components. So I think I will start
> migrating the pipeline editor now and maybe we can get this finished before
> the next release.
>
>
>
> So as this implies a rather major refactoring anyways, I’m interested if
> you see any things in the UI of the pipeline editor that could be improved
> or things you are missing?
>
> Any thoughts and ideas are welcome 😊
>
>
>
> Dominik
>
>
>
> [1] https://issues.apache.org/jira/browse/STREAMPIPES-145
>
>