You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/13 09:02:06 UTC
[PR] fix(web): guard topic detail requests and surface send errors [rocketmq-dashboard]
yyqdbngt opened a new pull request, #2095:
URL: https://github.com/apache/rocketmq-dashboard/pull/2095
## What is the purpose of the change
Fix #2082 (and #2084).
The topic detail dialog started multiple async requests without a generation guard, so rapid topic switching let a slow older response clear the loading state while the newer request was still in flight. The topic send handler also swallowed the server's specific error message.
## Brief changelog
- topic.tsx: guard detail requests with a detailRequestIdRef
- topic.tsx: surface the underlying error message when a send fails
## How was this patch verified
- npx vitest run src/pages/instance/__tests__/TopicPage.test.tsx (11 passed)
- npx tsc -b clean
- npx eslint . clean (0 errors)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): guard topic detail requests and surface send errors [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2095: fix(web): guard topic detail requests and surface send errors
URL: https://github.com/apache/rocketmq-dashboard/pull/2095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): guard topic detail requests and surface send errors [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2095:
URL: https://github.com/apache/rocketmq-dashboard/pull/2095#issuecomment-5289158535
Consolidated into #2098 as part of the batch consolidation of @yyqdbngt's web PRs (merged into rocketmq-studio). The change is preserved in the merged commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org