You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by ra...@apache.org on 2004/07/01 18:24:12 UTC

cvs commit: modperl-2.0/t/api sendfile.t

randyk      2004/07/01 09:24:12

  Modified:    t/api    sendfile.t
  Log:
  Reviewed by:	stas
  need to open a file using binmode on Win32, so as the \r are included,
  as these appear in the contents sent via sendfile.
  
  Revision  Changes    Path
  1.8       +3 -0      modperl-2.0/t/api/sendfile.t
  
  Index: sendfile.t
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/t/api/sendfile.t,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- sendfile.t	29 Jun 2004 22:56:16 -0000	1.7
  +++ sendfile.t	1 Jul 2004 16:24:12 -0000	1.8
  @@ -20,6 +20,9 @@
   
       open my $fh, $file or die "can't open $file: $!";
       local $/;
  +    # need binmode on Win32 so as not to strip \r, which
  +    # are included when sending with sendfile().
  +    binmode $fh;
       my $expected = join '', $header, <$fh>, $footer;
       close $fh;