You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2008/02/06 14:41:10 UTC
[jira] Created: (SHINDIG-52) Use Maven Javascript Plugin to enable
better builds
Use Maven Javascript Plugin to enable better builds
---------------------------------------------------
Key: SHINDIG-52
URL: https://issues.apache.org/jira/browse/SHINDIG-52
Project: Shindig
Issue Type: Improvement
Components: Javascript
Reporter: Paul Lindner
Assignee: Kevin Brown
It would be great if the maven build process could incorporate the Javascript plugin mentioned here:
http://hammerfest.sourceforge.net/maven-javascript-plugin/
I'll have a look at how difficult it is to enable this. It would be nice to have minified javascript and multiple files combined into a single compilation unit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-52) Use Maven Javascript Plugin to enable
better builds
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-52.
------------------------------
Resolution: Fixed
Closing this since we have a solution now that's mostly working (YUI compressor).
I don't actually like the solution we have for several reasons, but we'll have to revisit what we're doing with regards to minification in the future. We may be able to just leverage caja's parser to deal with minification.
> Use Maven Javascript Plugin to enable better builds
> ---------------------------------------------------
>
> Key: SHINDIG-52
> URL: https://issues.apache.org/jira/browse/SHINDIG-52
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Paul Lindner
> Assignee: Kevin Brown
>
> It would be great if the maven build process could incorporate the Javascript plugin mentioned here:
> http://hammerfest.sourceforge.net/maven-javascript-plugin/
> I'll have a look at how difficult it is to enable this. It would be nice to have minified javascript and multiple files combined into a single compilation unit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-52) Use Maven Javascript Plugin to
enable better builds
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569581#action_12569581 ]
Paul Lindner commented on SHINDIG-52:
-------------------------------------
Our internal build system uses ant and yuicompressor, so I'm not much help here..
I tried to get this working earlier and didn't have much luck. I'm building up my maven skills though so I might try again and see what I can accomplish.
> Use Maven Javascript Plugin to enable better builds
> ---------------------------------------------------
>
> Key: SHINDIG-52
> URL: https://issues.apache.org/jira/browse/SHINDIG-52
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Paul Lindner
> Assignee: Kevin Brown
>
> It would be great if the maven build process could incorporate the Javascript plugin mentioned here:
> http://hammerfest.sourceforge.net/maven-javascript-plugin/
> I'll have a look at how difficult it is to enable this. It would be nice to have minified javascript and multiple files combined into a single compilation unit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-52) Use Maven Javascript Plugin to
enable better builds
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566689#action_12566689 ]
Kevin Brown commented on SHINDIG-52:
------------------------------------
Minification alone would probably be sufficient, since the js servlet already handles concatenation. I'd love to have two versions of every js file (both a "debug" and a "release" version) so that shindig could support a debug flag that would serve the unminified js along side the minified stuff.
> Use Maven Javascript Plugin to enable better builds
> ---------------------------------------------------
>
> Key: SHINDIG-52
> URL: https://issues.apache.org/jira/browse/SHINDIG-52
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Reporter: Paul Lindner
> Assignee: Kevin Brown
>
> It would be great if the maven build process could incorporate the Javascript plugin mentioned here:
> http://hammerfest.sourceforge.net/maven-javascript-plugin/
> I'll have a look at how difficult it is to enable this. It would be nice to have minified javascript and multiple files combined into a single compilation unit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-52) Use Maven Javascript Plugin to
enable better builds
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569512#action_12569512 ]
Kevin Brown commented on SHINDIG-52:
------------------------------------
Has anyone looked into this recently? We're considering using some internal tools for this task when rolling up our builds at Google, but we do have a certain preference for keeping our code as close to "stock" Shindig as makes sense for us. If not, I'll play with it and see if we can get the desired results.
In a nutshell, what I'd like to see happen is this:
Input file: trunk/features/core/prefs.js (includes all comments and such)
Output file: war/features/core/prefs.js (minified as much as possible)
Nice to have bonus:
Additional output file: war/features/core/prefs.debug.js (same as original source file; we can add special logic for allowing a "debug" retrieval as well as a normal one.
> Use Maven Javascript Plugin to enable better builds
> ---------------------------------------------------
>
> Key: SHINDIG-52
> URL: https://issues.apache.org/jira/browse/SHINDIG-52
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Paul Lindner
> Assignee: Kevin Brown
>
> It would be great if the maven build process could incorporate the Javascript plugin mentioned here:
> http://hammerfest.sourceforge.net/maven-javascript-plugin/
> I'll have a look at how difficult it is to enable this. It would be nice to have minified javascript and multiple files combined into a single compilation unit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-52) Use Maven Javascript Plugin to enable
better builds
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown updated SHINDIG-52:
-------------------------------
Component/s: (was: Javascript)
Gadgets Server - Java
> Use Maven Javascript Plugin to enable better builds
> ---------------------------------------------------
>
> Key: SHINDIG-52
> URL: https://issues.apache.org/jira/browse/SHINDIG-52
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Paul Lindner
> Assignee: Kevin Brown
>
> It would be great if the maven build process could incorporate the Javascript plugin mentioned here:
> http://hammerfest.sourceforge.net/maven-javascript-plugin/
> I'll have a look at how difficult it is to enable this. It would be nice to have minified javascript and multiple files combined into a single compilation unit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-52) Use Maven Javascript Plugin to
enable better builds
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569704#action_12569704 ]
Paul Lindner commented on SHINDIG-52:
-------------------------------------
It was quite easy to set up YUIcompressor
http://alchim.sourceforge.net/yuicompressor-maven-plugin/
Index: java/gadgets/pom.xml
===================================================================
--- java/gadgets/pom.xml (revision 628435)
+++ java/gadgets/pom.xml (working copy)
@@ -102,6 +102,22 @@
<groupId>org.mortbay.jetty</groupId>
<artifactId>maven-jetty-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>net.sf.alchim</groupId>
+ <artifactId>yuicompressor-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>compress</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <nosuffix>true</nosuffix>
+ </configuration>
+
+ </plugin>
+
</plugins>
<resources>
<resource>
This only does stuff in the features directory, not the container files, but it's a start...
> Use Maven Javascript Plugin to enable better builds
> ---------------------------------------------------
>
> Key: SHINDIG-52
> URL: https://issues.apache.org/jira/browse/SHINDIG-52
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Paul Lindner
> Assignee: Kevin Brown
>
> It would be great if the maven build process could incorporate the Javascript plugin mentioned here:
> http://hammerfest.sourceforge.net/maven-javascript-plugin/
> I'll have a look at how difficult it is to enable this. It would be nice to have minified javascript and multiple files combined into a single compilation unit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.