You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2013/01/15 19:30:06 UTC

svn commit: r1433569 [12/12] - in /httpcomponents: benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/ benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/ benchmark/httpcore/trunk/src/main/java/org/apache/http/bench...

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/params/TestDefaultedHttpParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/params/TestDefaultedHttpParams.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/params/TestDefaultedHttpParams.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/params/TestDefaultedHttpParams.java Tue Jan 15 18:29:58 2013
@@ -66,7 +66,7 @@ public class TestDefaultedHttpParams {
         Assert.assertEquals(0, deflt.getDefaultNames().size());
     }
 
-    private HttpParams addParams(String name){
+    private HttpParams addParams(final String name){
         BasicHttpParams params = new BasicHttpParams();
         params.setParameter("common","both");
         params.setParameter(name,"value");

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestConnPool.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestConnPool.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestConnPool.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestConnPool.java Tue Jan 15 18:29:58 2013
@@ -70,7 +70,7 @@ public class TestConnPool {
 
         public LocalConnPool(
                 final ConnFactory<String, HttpConnection> connFactory,
-                int defaultMaxPerRoute, int maxTotal) {
+                final int defaultMaxPerRoute, final int maxTotal) {
             super(connFactory, defaultMaxPerRoute, maxTotal);
         }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestPoolEntry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestPoolEntry.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestPoolEntry.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/pool/TestPoolEntry.java Tue Jan 15 18:29:58 2013
@@ -40,12 +40,12 @@ public class TestPoolEntry {
     static class MockPoolEntry extends PoolEntry<String, HttpConnection> {
 
         public MockPoolEntry(final String route,
-                long timeToLive, final TimeUnit tunit) {
+                final long timeToLive, final TimeUnit tunit) {
             super(null, route, Mockito.mock(HttpConnection.class), timeToLive, tunit);
         }
 
         public MockPoolEntry(final String route, final HttpConnection conn,
-                long timeToLive, final TimeUnit tunit) {
+                final long timeToLive, final TimeUnit tunit) {
             super(null, route, conn, timeToLive, tunit);
         }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/protocol/TestBasicHttpProcessor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/protocol/TestBasicHttpProcessor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/protocol/TestBasicHttpProcessor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/protocol/TestBasicHttpProcessor.java Tue Jan 15 18:29:58 2013
@@ -41,8 +41,8 @@ public class TestBasicHttpProcessor {
     static class TestHttpRequestInterceptorPlaceHolder implements HttpRequestInterceptor {
 
         public void process(
-                HttpRequest request,
-                HttpContext context) throws HttpException, IOException {
+                final HttpRequest request,
+                final HttpContext context) throws HttpException, IOException {
         }
     }
 
@@ -110,8 +110,8 @@ public class TestBasicHttpProcessor {
         HttpRequestInterceptor itcp3 = new HttpRequestInterceptor() {
 
             public void process(
-                    HttpRequest request,
-                    HttpContext context) throws HttpException, IOException {
+                    final HttpRequest request,
+                    final HttpContext context) throws HttpException, IOException {
             }
 
         };

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpClient.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpClient.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpClient.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpClient.java Tue Jan 15 18:29:58 2013
@@ -87,7 +87,7 @@ public class HttpClient {
         return this.timeout;
     }
 
-    public void setTimeout(int timeout) {
+    public void setTimeout(final int timeout) {
         this.timeout = timeout;
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpServer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpServer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpServer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/HttpServer.java Tue Jan 15 18:29:58 2013
@@ -87,7 +87,7 @@ public class HttpServer {
         return this.timeout;
     }
 
-    public void setTimeout(int timeout) {
+    public void setTimeout(final int timeout) {
         this.timeout = timeout;
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpClientConnection.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpClientConnection.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpClientConnection.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpClientConnection.java Tue Jan 15 18:29:58 2013
@@ -56,7 +56,7 @@ public class LoggingBHttpClientConnectio
     private final Wire wire;
 
     public LoggingBHttpClientConnection(
-            int buffersize,
+            final int buffersize,
             final CharsetDecoder chardecoder,
             final CharsetEncoder charencoder,
             final MessageConstraints constraints,
@@ -73,7 +73,7 @@ public class LoggingBHttpClientConnectio
         this.wire = new Wire(LogFactory.getLog("org.apache.http.wire"), this.id);
     }
 
-    public LoggingBHttpClientConnection(int buffersize) {
+    public LoggingBHttpClientConnection(final int buffersize) {
         this(buffersize, null, null, null, null, null, null, null);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpServerConnection.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpServerConnection.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpServerConnection.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingBHttpServerConnection.java Tue Jan 15 18:29:58 2013
@@ -56,7 +56,7 @@ public class LoggingBHttpServerConnectio
     private final Wire wire;
 
     public LoggingBHttpServerConnection(
-            int buffersize,
+            final int buffersize,
             final CharsetDecoder chardecoder,
             final CharsetEncoder charencoder,
             final MessageConstraints constraints,
@@ -73,7 +73,7 @@ public class LoggingBHttpServerConnectio
         this.wire = new Wire(LogFactory.getLog("org.apache.http.wire"), this.id);
     }
 
-    public LoggingBHttpServerConnection(int buffersize) {
+    public LoggingBHttpServerConnection(final int buffersize) {
         this(buffersize, null, null, null, null, null, null, null);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingInputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingInputStream.java Tue Jan 15 18:29:58 2013
@@ -51,7 +51,7 @@ class LoggingInputStream extends InputSt
     }
 
     @Override
-    public int read(byte[] b) throws IOException {
+    public int read(final byte[] b) throws IOException {
         int bytesRead = in.read(b);
         if (bytesRead != -1) {
             wire.input(b, 0, bytesRead);
@@ -60,7 +60,7 @@ class LoggingInputStream extends InputSt
     }
 
     @Override
-    public int read(byte[] b, int off, int len) throws IOException {
+    public int read(final byte[] b, final int off, final int len) throws IOException {
         int bytesRead = in.read(b, off, len);
         if (bytesRead != -1) {
             wire.input(b, off, bytesRead);
@@ -69,7 +69,7 @@ class LoggingInputStream extends InputSt
     }
 
     @Override
-    public long skip(long n) throws IOException {
+    public long skip(final long n) throws IOException {
         return super.skip(n);
     }
 
@@ -79,7 +79,7 @@ class LoggingInputStream extends InputSt
     }
 
     @Override
-    public synchronized void mark(int readlimit) {
+    public synchronized void mark(final int readlimit) {
         super.mark(readlimit);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingOutputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingOutputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingOutputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/LoggingOutputStream.java Tue Jan 15 18:29:58 2013
@@ -42,18 +42,18 @@ class LoggingOutputStream extends Output
     }
 
     @Override
-    public void write(int b) throws IOException {
+    public void write(final int b) throws IOException {
         wire.output(b);
     }
 
     @Override
-    public void write(byte[] b) throws IOException {
+    public void write(final byte[] b) throws IOException {
         wire.output(b);
         out.write(b);
     }
 
     @Override
-    public void write(byte[] b, int off, int len) throws IOException {
+    public void write(final byte[] b, final int off, final int len) throws IOException {
         wire.output(b, off, len);
         out.write(b, off, len);
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/Wire.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/Wire.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/Wire.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/testserver/Wire.java Tue Jan 15 18:29:58 2013
@@ -40,7 +40,7 @@ class Wire {
         this.id = id;
     }
 
-    private void wire(final String header, final byte[] b, int pos, int off) {
+    private void wire(final String header, final byte[] b, final int pos, final int off) {
         StringBuilder buffer = new StringBuilder();
         for (int i = 0; i < off; i++) {
             int ch = b[pos + i];
@@ -73,27 +73,27 @@ class Wire {
         return this.log.isDebugEnabled();
     }
 
-    public void output(final byte[] b, int pos, int off) {
+    public void output(final byte[] b, final int pos, final int off) {
         wire("<< ", b, pos, off);
     }
 
-    public void input(final byte[] b, int pos, int off) {
+    public void input(final byte[] b, final int pos, final int off) {
         wire(">> ", b, pos, off);
     }
 
-    public void output(byte[] b) {
+    public void output(final byte[] b) {
         output(b, 0, b.length);
     }
 
-    public void input(byte[] b) {
+    public void input(final byte[] b) {
         input(b, 0, b.length);
     }
 
-    public void output(int b) {
+    public void output(final int b) {
         output(new byte[] {(byte) b});
     }
 
-    public void input(int b) {
+    public void input(final int b) {
         input(new byte[] {(byte) b});
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEncodingUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEncodingUtils.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEncodingUtils.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEncodingUtils.java Tue Jan 15 18:29:58 2013
@@ -36,7 +36,7 @@ import org.junit.Test;
  */
 public class TestEncodingUtils {
 
-    private static String constructString(int [] unicodeChars) {
+    private static String constructString(final int [] unicodeChars) {
         StringBuilder buffer = new StringBuilder();
         if (unicodeChars != null) {
             for (int unicodeChar : unicodeChars) {

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEntityUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEntityUtils.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEntityUtils.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/util/TestEntityUtils.java Tue Jan 15 18:29:58 2013
@@ -160,7 +160,7 @@ public class TestEntityUtils {
         0x432, 0x435, 0x442
     };
 
-    private static String constructString(int [] unicodeChars) {
+    private static String constructString(final int [] unicodeChars) {
         StringBuilder buffer = new StringBuilder();
         if (unicodeChars != null) {
             for (int unicodeChar : unicodeChars) {