You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/05 12:14:39 UTC
[GitHub] [cordova-docs] mosabab opened a new pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
mosabab opened a new pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103
… information
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
- How to install ios-deploy tool in correct way.
- Add missing information about CocoaPods tools that needed to build iOS apps.
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab closed pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab closed pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek edited a comment on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669173619
https://github.com/apache/cordova-docs/pull/1095 appears to be a copy of this one?
https://github.com/apache/cordova-docs/pull/1102/files looks good as is, I'll reopen that one.
edit: err I can't reopen the PR because the remote has been deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab commented on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669166984
> I think this PR should be actually two separate PRs.
>
> One change for the CocoaPods update, the other for the ios-deploy update. Otherwise I think they are good.
I was closed the separated 2 PRs in the following:
https://github.com/apache/cordova-docs/pull/1095
https://github.com/apache/cordova-docs/pull/1102
I can close this one and reopen the 2 closed, but it same information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek commented on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669173619
https://github.com/apache/cordova-docs/pull/1095 appears to be a copy of this one?
https://github.com/apache/cordova-docs/pull/1102/files looks good as is, I'll reopen that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab commented on a change in pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab commented on a change in pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#discussion_r465686171
##########
File path: www/docs/en/dev/guide/platforms/ios/index.md
##########
@@ -69,10 +69,20 @@ $ xcode-select --install
The [ios-deploy](https://www.npmjs.org/package/ios-deploy) tools allow you
to launch iOS apps on an iOS Device from the command-line.
-To install it, run the following from command-line terminal:
+Install ios-deploy via [Homebrew](https://brew.sh/) by running:
```bash
-$ npm install -g ios-deploy
+$ brew install ios-deploy
Review comment:
And also you can refer to installation guide at npm main page for the ios-deolpy:
https://www.npmjs.com/package/ios-deploy#installation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab edited a comment on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669166984
> I think this PR should be actually two separate PRs.
>
> One change for the CocoaPods update, the other for the ios-deploy update. Otherwise I think they are good.
I was close the 2 separated PRs in the following:
https://github.com/apache/cordova-docs/pull/1095
https://github.com/apache/cordova-docs/pull/1102
I can close this one and reopen the closed PRs, but it same information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab edited a comment on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669166984
> I think this PR should be actually two separate PRs.
>
> One change for the CocoaPods update, the other for the ios-deploy update. Otherwise I think they are good.
I was close the 2 separated PRs in the following:
https://github.com/apache/cordova-docs/pull/1095
https://github.com/apache/cordova-docs/pull/1102
This PR merge the 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek commented on a change in pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#discussion_r465683640
##########
File path: www/docs/en/dev/guide/platforms/ios/index.md
##########
@@ -69,10 +69,20 @@ $ xcode-select --install
The [ios-deploy](https://www.npmjs.org/package/ios-deploy) tools allow you
to launch iOS apps on an iOS Device from the command-line.
-To install it, run the following from command-line terminal:
+Install ios-deploy via [Homebrew](https://brew.sh/) by running:
```bash
-$ npm install -g ios-deploy
+$ brew install ios-deploy
Review comment:
What's wrong with installing `ios-deploy` from npm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek commented on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669164663
I think this PR should be actually two separate PRs.
One change for the CocoaPods update, the other for the ios-deploy update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab commented on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669180619
Close this one.
And open 2 new separated PR:
https://github.com/apache/cordova-docs/pull/1104
https://github.com/apache/cordova-docs/pull/1105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab edited a comment on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669166984
> I think this PR should be actually two separate PRs.
>
> One change for the CocoaPods update, the other for the ios-deploy update. Otherwise I think they are good.
I was close the 2 separated PRs in the following:
https://github.com/apache/cordova-docs/pull/1095
https://github.com/apache/cordova-docs/pull/1102
This PR merge the 2.
Feel free to reopen the closed 2 PRs. And close this one. what do you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab commented on a change in pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab commented on a change in pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#discussion_r465685222
##########
File path: www/docs/en/dev/guide/platforms/ios/index.md
##########
@@ -69,10 +69,20 @@ $ xcode-select --install
The [ios-deploy](https://www.npmjs.org/package/ios-deploy) tools allow you
to launch iOS apps on an iOS Device from the command-line.
-To install it, run the following from command-line terminal:
+Install ios-deploy via [Homebrew](https://brew.sh/) by running:
```bash
-$ npm install -g ios-deploy
+$ brew install ios-deploy
Review comment:
On macOS there is an error if you try to install it from npm.
According to the main page of ios-deploy, please refer to new installation guide:
https://github.com/ios-control/ios-deploy#Installation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu commented on a change in pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#discussion_r465689564
##########
File path: www/docs/en/dev/guide/platforms/ios/index.md
##########
@@ -69,10 +69,20 @@ $ xcode-select --install
The [ios-deploy](https://www.npmjs.org/package/ios-deploy) tools allow you
to launch iOS apps on an iOS Device from the command-line.
-To install it, run the following from command-line terminal:
+Install ios-deploy via [Homebrew](https://brew.sh/) by running:
```bash
-$ npm install -g ios-deploy
+$ brew install ios-deploy
Review comment:
```
$ brew info ios-deploy
ios-deploy: stable 1.10.0 (bottled), HEAD
```
`brew` has version `1.10.0` released.
```
$ npm info ios-deploy
ios-deploy@1.11.0 | GPLv3 | deps: none | versions: 41
```
`npm` has version `1.11.0` released.
Just for information, `npm` appears to be newer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek edited a comment on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669164663
I think this PR should be actually two separate PRs.
One change for the CocoaPods update, the other for the ios-deploy update. Otherwise I think they are good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] mosabab commented on pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#issuecomment-669177483
> #1095 appears to be a copy of this one?
>
> https://github.com/apache/cordova-docs/pull/1102/files looks good as is, I'll reopen that one.
>
> edit: err I can't reopen the PR because the remote has been deleted.
I will make new 2 separated PR for this .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu commented on a change in pull request #1103: [iOS] install ios-deploy in correct way & add missing CocoaPods tools…
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1103:
URL: https://github.com/apache/cordova-docs/pull/1103#discussion_r465689564
##########
File path: www/docs/en/dev/guide/platforms/ios/index.md
##########
@@ -69,10 +69,20 @@ $ xcode-select --install
The [ios-deploy](https://www.npmjs.org/package/ios-deploy) tools allow you
to launch iOS apps on an iOS Device from the command-line.
-To install it, run the following from command-line terminal:
+Install ios-deploy via [Homebrew](https://brew.sh/) by running:
```bash
-$ npm install -g ios-deploy
+$ brew install ios-deploy
Review comment:
```
$ brew info ios-deploy
ios-deploy: stable 1.10.0 (bottled), HEAD
```
`brew` has version `1.10.0` released.
```
$ npm info ios-deploy
ios-deploy@1.11.0 | GPLv3 | deps: none | versions: 41
```
`npm` has version `1.11.0` released.
Just for information, `npm` is newer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org