You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by cm...@apache.org on 2011/02/02 18:16:40 UTC

svn commit: r1066540 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

Author: cmpilato
Date: Wed Feb  2 17:16:40 2011
New Revision: 1066540

URL: http://svn.apache.org/viewvc?rev=1066540&view=rev
Log:
* subversion/libsvn_ra_serf/util.c
  (svn_ra_serf__discover_vcc): Fix while() condition to avoid bailing
    out of loop too early.  While here, correct an error message that
    referred to an OPTIONS request when a PROPFIND was used.

Modified:
    subversion/trunk/subversion/libsvn_ra_serf/util.c

Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util.c?rev=1066540&r1=1066539&r2=1066540&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/util.c Wed Feb  2 17:16:40 2011
@@ -1807,12 +1807,12 @@ svn_ra_serf__discover_vcc(const char **v
         }
     }
   while ((path[0] != '\0')
-         && (! (path[0] == '/') && (path[1] == '\0')));
+         && (! (path[0] == '/' && path[1] == '\0')));
 
   if (!*vcc_url)
     {
       return svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
-                              _("The OPTIONS response did not include the "
+                              _("The PROPFIND response did not include the "
                                 "requested version-controlled-configuration "
                                 "value"));
     }



Re: svn commit: r1066540 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

Posted by Julian Foad <ju...@wandisco.com>.
On Wed, 2011-02-02, cmpilato@apache.org wrote:
> Author: cmpilato
> Date: Wed Feb  2 17:16:40 2011
> New Revision: 1066540
> 
> URL: http://svn.apache.org/viewvc?rev=1066540&view=rev
> Log:
> * subversion/libsvn_ra_serf/util.c
>   (svn_ra_serf__discover_vcc): Fix while() condition to avoid bailing
>     out of loop too early.

What is the functional change?  (Bug fix?)

- Julian


>   While here, correct an error message that
>     referred to an OPTIONS request when a PROPFIND was used.
> 
> Modified:
>     subversion/trunk/subversion/libsvn_ra_serf/util.c
> 
> Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util.c?rev=1066540&r1=1066539&r2=1066540&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Wed Feb  2 17:16:40 2011
> @@ -1807,12 +1807,12 @@ svn_ra_serf__discover_vcc(const char **v
>          }
>      }
>    while ((path[0] != '\0')
> -         && (! (path[0] == '/') && (path[1] == '\0')));
> +         && (! (path[0] == '/' && path[1] == '\0')));
>  
>    if (!*vcc_url)
>      {
>        return svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
> -                              _("The OPTIONS response did not include the "
> +                              _("The PROPFIND response did not include the "
>                                  "requested version-controlled-configuration "
>                                  "value"));
>      }
> 
>