[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

[GitBox <gi...@apache.org>]

andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#issuecomment-539800079
 
 
   > If every JS snippet is ending up as a header item anyway, why not remove <priority-evaluate> and <evaluate> from the Ajax response and transport everything as a <header-contribution>?
   > In the correct order of course.
   > 
   > <script> and <style> already have a nonce-attribute, so we don't need to invent something new to transport that information in the Ajax response.
   > With WICKET-6703 we will have 4 paths* in wicket-ajax-jquery.js to add <script> to the DOM, which could all be unified:
   > 
   > ```
   > [<header-contribution>]
   > -> processHeaderContribution	
   >   -> Wicket.Head.Contributor.processContribution
   >     -> processScript
   >       [has "src"]
   >         -> Wicket.Head.addElement
   >       [has "id"]
   >         -> addJavascript
   >           -> Wicket.Head.addElement
   >       [otherwise]
   >         -> jQuery.globalEval
   > 
   > [<priority-evaluate> or <evaluate>]
   > -> processEvaluation
   >   -> jQuery.globalEval
   > ```
   
   I think this could work. Just before I start with this, what do others think? @martin-g ? @solomax ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services