You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/17 20:27:28 UTC

[GitHub] [incubator-superset] wisefool769 opened a new pull request #9574: sybase db_engine_spec

wisefool769 opened a new pull request #9574: sybase db_engine_spec
URL: https://github.com/apache/incubator-superset/pull/9574
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Add a Sybase db_engine_spec, inheriting from the Mssql one.
   Fixes [#9573](https://github.com/apache/incubator-superset/issues/9573)
   
   ### TEST PLAN
   Try connecting to a Sybase database and verify that SQL Lab works properly now.
   I tried on my end and it works fine, while before it gave a syntax error.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9574: sybase db_engine_spec
URL: https://github.com/apache/incubator-superset/pull/9574#discussion_r410736157
 
 

 ##########
 File path: superset/db_engine_specs/sybase.py
 ##########
 @@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from superset.db_engine_specs.mssql import MssqlEngineSpec
+
+
+class SybaseEngineSpec(MssqlEngineSpec):
+    engine = "sybase"
 
 Review comment:
   In my experience, extending an existing engine spec is usually a bad pattern, and based on very quick googling Sybase doesn't seem to be directly related to MSSQL (I have zero experience with Sybase, unfortunately). If you wish, you can copy the contents of `mssql.py` into `sybase.py`, and then start tweaking from there. However, if Sybase and MSSQL have a lot in common, this might not be necessary.
   
   There are a few minimum features that a b engine spec need, namely:
   - time grain expressions: these are expressions that round dates, datetimes and timestamps down to a wanted timegrain. Without time grains your Superset experience will be very limited. If the MSSQL time grains work with Sybase, you won't need to reinvent the wheel here.
   - `epoch_to_dttm`  method: this defines an expression that takes an epoch (seconds since 1970-01-01 00:00:00) and changes it to a datetime. Again, if the MSSQL version works, use that.
   - `convert_dttm` method: expression for casting a python `datetime` into a DATE/DATETIME/TIMESTAMP type in the given SQL dialect.
   
   We also try to add unit tests for all db engine specs nowadays (check `tests/db_engine_specs/`), but don't worry about that if you don't feel comfortable writing tests.
   
   Oh, please feel free to reach out on Slack if you need help 🙂  Good luck!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] wisefool769 commented on issue #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
wisefool769 commented on issue #9574: sybase db_engine_spec
URL: https://github.com/apache/incubator-superset/pull/9574#issuecomment-615453186
 
 
   I have one failure for some test that my change shouldn't have affected. Based on this trace, I suspect that it's just a race condition, and that rerunning may fix. Can we try that?
   
   ```
   Dataset API: Test export dataset ... FAIL
   
   ======================================================================
   FAIL: Dataset API: Test export dataset
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/home/runner/work/incubator-superset/incubator-superset/tests/datasets/api_tests.py", line 702, in test_export_dataset
       generate_download_headers("yaml")["Content-Disposition"],
   AssertionError: 'attachment; filename=20200417_203103.yaml' != 'attachment; filename=20200417_203104.yaml'
   - attachment; filename=20200417_203103.yaml
   ?                                    ^
   + attachment; filename=20200417_203104.yaml
   ?                                    ^
   
       """Fail immediately, with the given message."""
   >>  raise self.failureException("'attachment; filename=20200417_203103.yaml' != 'attachment; filename=20200417_203104.yaml'\n- attachment; filename=20200417_203103.yaml\n?                                    ^\n+ attachment; filename=20200417_203104.yaml\n?                                    ^\n")
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9574: sybase db_engine_spec
URL: https://github.com/apache/incubator-superset/pull/9574#issuecomment-615451114
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=h1) Report
   > Merging [#9574](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.59%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9574/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9574      +/-   ##
   ==========================================
   + Coverage   65.62%   70.21%   +4.59%     
   ==========================================
     Files         574      575       +1     
     Lines       30060    30063       +3     
     Branches     3054     3054              
   ==========================================
   + Hits        19726    21110    +1384     
   + Misses      10150     8835    -1315     
   + Partials      184      118      -66     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `52.89% <ø> (?)` | |
   | #javascript | `58.75% <ø> (ø)` | |
   | #python | `70.38% <100.00%> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/sybase.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3N5YmFzZS5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (+0.65%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (+1.28%)` | :arrow_up: |
   | [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
   | ... and [136 more](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=footer). Last update [ea27e68...c9935c4](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9574: sybase db_engine_spec
URL: https://github.com/apache/incubator-superset/pull/9574#issuecomment-615451114
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=h1) Report
   > Merging [#9574](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9574/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9574      +/-   ##
   ==========================================
   - Coverage   65.62%   65.58%   -0.04%     
   ==========================================
     Files         574      575       +1     
     Lines       30060    30063       +3     
     Branches     3054     3054              
   ==========================================
   - Hits        19726    19717       -9     
   - Misses      10150    10162      +12     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `58.75% <ø> (ø)` | |
   | #python | `70.38% <100.00%> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/sybase.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3N5YmFzZS5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=footer). Last update [ea27e68...c9935c4](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9574: sybase db_engine_spec
URL: https://github.com/apache/incubator-superset/pull/9574#issuecomment-615451114
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=h1) Report
   > Merging [#9574](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.80%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9574/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9574      +/-   ##
   ==========================================
   + Coverage   65.62%   70.42%   +4.80%     
   ==========================================
     Files         574      575       +1     
     Lines       30060    30063       +3     
     Branches     3054     3054              
   ==========================================
   + Hits        19726    21171    +1445     
   + Misses      10150     8780    -1370     
   + Partials      184      112      -72     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.68% <ø> (?)` | |
   | #javascript | `58.75% <ø> (ø)` | |
   | #python | `70.38% <100.00%> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/sybase.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3N5YmFzZS5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `56.98% <0.00%> (+1.07%)` | :arrow_up: |
   | [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <0.00%> (+1.69%)` | :arrow_up: |
   | ... and [138 more](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=footer). Last update [ea27e68...c9935c4](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9574: sybase db_engine_spec
URL: https://github.com/apache/incubator-superset/pull/9574#issuecomment-615451114
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=h1) Report
   > Merging [#9574](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `6.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9574/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9574      +/-   ##
   ==========================================
   - Coverage   65.62%   58.75%   -6.87%     
   ==========================================
     Files         574      392     -182     
     Lines       30060    12414   -17646     
     Branches     3054     3054              
   ==========================================
   - Hits        19726     7294   -12432     
   + Misses      10150     4936    -5214     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `58.75% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | | |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | | |
   | [superset/examples/paris.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | | |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | | |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | | |
   | [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | | |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | | |
   | [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | | |
   | [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | | |
   | ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/9574/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=footer). Last update [ea27e68...c9935c4](https://codecov.io/gh/apache/incubator-superset/pull/9574?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] closed pull request #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #9574:
URL: https://github.com/apache/incubator-superset/pull/9574


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on pull request #9574: sybase db_engine_spec

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9574:
URL: https://github.com/apache/incubator-superset/pull/9574#issuecomment-645560384


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org