[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34008: [SPARK-36740][SQL] ArrayMin/ArrayMax/SortArray/ArraySort add comment and Unit test

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34008:
URL: https://github.com/apache/spark/pull/34008#discussion_r709319930



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -2339,4 +2339,22 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
       Literal.create(Seq(Float.NaN, null), ArrayType(FloatType)),
       Literal.create(Seq(Float.NaN, null, 1f), ArrayType(FloatType))), true)
   }
+
+  test("SPARK-36740: ArrayMin/ArrayMax/SortArray add comment and unit test for " +

Review comment:
       In this case, could you describe the content of this test case instead of PR title?

##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
##########
@@ -832,4 +832,10 @@ class HigherOrderFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper
     assert(mapFilter2_1.semanticEquals(mapFilter2_2))
     assert(!mapFilter2_1.semanticEquals(mapFilter2_3))
   }
+
+  test("SPARK-36740: ArraySort add comment and unit test for Double.NaN and Float.NaN") {

Review comment:
       In this case, could you describe the content of this test case instead of PR title?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org