You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/02/15 02:24:40 UTC
[jira] Created: (HARMONY-92) Suggestion: Move com.ibm.platform from
NIO to LUNI
Suggestion: Move com.ibm.platform from NIO to LUNI
--------------------------------------------------
Key: HARMONY-92
URL: http://issues.apache.org/jira/browse/HARMONY-92
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Richard Liang
Hello Tim,
As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-92) Suggestion: Move com.ibm.platform
from NIO to LUNI
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=comments#action_12366423 ]
Richard Liang commented on HARMONY-92:
--------------------------------------
According to the "package naming convention" (http://incubator.apache.org/harmony/subcomponents/classlibrary/pkgnaming.html), I suggest we rename com.ibm.platform to org.apache.harmony.luni.platform, and com.ibm.platform.struct to org.apache.harmony.luni.platform.struct
Any comments?
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-92) Suggestion: Move com.ibm.platform
from NIO to LUNI
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=comments#action_12369215 ]
Mark Hindess commented on HARMONY-92:
-------------------------------------
Looks good. Thanks Tim.
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, refactor_platform.zip
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-92) Suggestion: Move com.ibm.platform
from NIO to LUNI
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]
Tim Ellison reassigned HARMONY-92:
----------------------------------
Assign To: Tim Ellison
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, refactor_platform.zip
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-92) Suggestion: Move com.ibm.platform from
NIO to LUNI
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]
Mark Hindess updated HARMONY-92:
--------------------------------
Attachment: new.refactor.tar.gz
I've created a new version of these changes (from scratch to avoid provenance issues giving Geir headaches).
There are scripts and patches numbered in order that they should be applied. It's broken down in to two stages - the nio to luni move and the rename. Check the README for details.
Richard, let me know if I've missed anything. Thanks.
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Attachments: new.refactor.tar.gz, refactor_platform.zip
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-92) Suggestion: Move com.ibm.platform from
NIO to LUNI
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]
Mark Hindess updated HARMONY-92:
--------------------------------
Attachment: 06.remove-obsolete.sh
If you apply my changes then a number of files are no longer required. The 06 script removes them.
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, refactor_platform.zip
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (HARMONY-92) Suggestion: Move com.ibm.platform
from NIO to LUNI
Posted by Richard Liang <ri...@gmail.com>.
Richard Liang (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-92?page=comments#action_12369166 ]
>
> Richard Liang commented on HARMONY-92:
> --------------------------------------
>
> Hello Mark,
>
> I think your patch is what I can though I just re-play your patch manually because I have no permission to check-in :-)
> Thanks a lot.
>
>
Forgive my carelessness. I mean your patch is what I want. Thanks a lot.
>> Suggestion: Move com.ibm.platform from NIO to LUNI
>> --------------------------------------------------
>>
>> Key: HARMONY-92
>> URL: http://issues.apache.org/jira/browse/HARMONY-92
>> Project: Harmony
>> Type: Improvement
>> Components: Classlib
>> Reporter: Richard Liang
>> Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, refactor_platform.zip
>>
>> Hello Tim,
>> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
>>
>
>
--
Richard Liang
China Software Development Lab, IBM
[jira] Commented: (HARMONY-92) Suggestion: Move com.ibm.platform
from NIO to LUNI
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=comments#action_12369166 ]
Richard Liang commented on HARMONY-92:
--------------------------------------
Hello Mark,
I think your patch is what I can though I just re-play your patch manually because I have no permission to check-in :-)
Thanks a lot.
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, refactor_platform.zip
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-92) Suggestion: Move com.ibm.platform
from NIO to LUNI
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]
Tim Ellison resolved HARMONY-92:
--------------------------------
Resolution: Fixed
Mark / Richard,
Thanks for the patches & instructions.
The 'platform' code has been moved from NIO to LUNI at repo revision 383849.
Please check that the patches were applied as you expected.
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, refactor_platform.zip
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (HARMONY-92) Suggestion: Move com.ibm.platform
from NIO to LUNI
Posted by Tim Ellison <t....@gmail.com>.
Richard,
I have had a look at your patch, but not applied it ...
I agree with moving this behavior into LUNI, but perhaps you would
consider refactoring to remove the distinction between platform and
platform.struct (which is historical), and adopting the proposed package
naming we have discussed on the list. So if you could refactor into
o.a.h.luni.platform and o.a.h.luni.internal.platform that would be better.
You also need to update the manifest files to reflect the package
refactoring, and the build patternsets.
What do you think?
Regards,
Tim
Richard Liang (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]
>
> Richard Liang updated HARMONY-92:
> ---------------------------------
>
> Attachment: refactor_platform.zip
>
> Hello,
> Here is the patch for this issue.
>
> 1. For java source, it's more convenient to use Eclipse's refact->move, rename (You can also copy files from the attachment)
> 2. For native source, please copy files from the attachment, then apply the patch file.
> (Though there are only some copy, paste, delete, and rename operations, we have done it for you.)
>
> Thanks a lot.
>
>> Suggestion: Move com.ibm.platform from NIO to LUNI
>> --------------------------------------------------
>>
>> Key: HARMONY-92
>> URL: http://issues.apache.org/jira/browse/HARMONY-92
>> Project: Harmony
>> Type: Improvement
>> Components: Classlib
>> Reporter: Richard Liang
>> Attachments: refactor_platform.zip
>>
>> Hello Tim,
>> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
[jira] Updated: (HARMONY-92) Suggestion: Move com.ibm.platform from
NIO to LUNI
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]
Richard Liang updated HARMONY-92:
---------------------------------
Attachment: refactor_platform.zip
Hello,
Here is the patch for this issue.
1. For java source, it's more convenient to use Eclipse's refact->move, rename (You can also copy files from the attachment)
2. For native source, please copy files from the attachment, then apply the patch file.
(Though there are only some copy, paste, delete, and rename operations, we have done it for you.)
Thanks a lot.
> Suggestion: Move com.ibm.platform from NIO to LUNI
> --------------------------------------------------
>
> Key: HARMONY-92
> URL: http://issues.apache.org/jira/browse/HARMONY-92
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Attachments: refactor_platform.zip
>
> Hello Tim,
> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira