[GitHub] [activemq] jbonofre commented on a change in pull request #784: Use Jetty atomic jar files instead of jetty-all (deprecated) and update to Jetty 9.4.45.v20220203

[GitBox <gi...@apache.org>]

jbonofre commented on a change in pull request #784:
URL: https://github.com/apache/activemq/pull/784#discussion_r815995938



##########
File path: activemq-amqp/pom.xml
##########
@@ -77,10 +77,13 @@
       <scope>test</scope>
     </dependency>
     <dependency>
-      <!-- using it for Jetty's JNDI context to work /w Joram tests. -->
-      <groupId>org.eclipse.jetty.aggregate</groupId>
-      <artifactId>jetty-all</artifactId>
-      <classifier>uber</classifier>
+      <groupId>org.eclipse.jetty</groupId>
+      <artifactId>jetty-server</artifactId>
+      <scope>test</scope>
+    </dependency>

Review comment:
       Let me give you some background:
   - jetty 9.4.45 contains new CVE fixes
   - just updating to jetty 9.4.45 using jetty-all uber jar won't work as jetty broke the uber jar
   So, that's why I did both changes in the same PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org