You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2014/06/17 02:08:05 UTC

Re: svn commit: r1602871 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

stsp@apache.org wrote on Mon, Jun 16, 2014 at 14:11:18 -0000:
> -#ifdef PACK_AFTER_EVERY_COMMIT

Should we make it an #error for PACK_AFTER_EVERY_COMMIT to be defined?
(in order to forcibly break any scripts that use the #define and expect it
to have an effect)

Daniel

Re: svn commit: r1602871 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Jun 17, 2014 at 12:08:05AM +0000, Daniel Shahaf wrote:
> stsp@apache.org wrote on Mon, Jun 16, 2014 at 14:11:18 -0000:
> > -#ifdef PACK_AFTER_EVERY_COMMIT
> 
> Should we make it an #error for PACK_AFTER_EVERY_COMMIT to be defined?
> (in order to forcibly break any scripts that use the #define and expect it
> to have an effect)
> 
> Daniel

I don't think many people have used this.
Are you aware of anyone other than yourself using this?

If you want this for your own builds, wouldn't adding this #error
definition to subversion/svn_private_config.h after running configure
do the trick?

  ./configure
  printf '#ifdef PACK_AFTER_EVERY_COMMIT\n#error "PACK_AFTER_EVERY_COMMIT is defined"\n#endif\n' >> subversion/svn_private_config.h
  make