You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rb...@apache.org on 2012/03/05 02:41:32 UTC

svn commit: r1296931 - in /httpd/httpd/branches/2.2.x/docs/manual/rewrite: rewritemap.html.en rewritemap.xml

Author: rbowen
Date: Mon Mar  5 01:41:32 2012
New Revision: 1296931

URL: http://svn.apache.org/viewvc?rev=1296931&view=rev
Log:
Note that RewriteLock should be used when using prg: style RewriteMaps
https://issues.apache.org/bugzilla/show_bug.cgi?id=52347

Modified:
    httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en
    httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml

Modified: httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en?rev=1296931&r1=1296930&r2=1296931&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en (original)
+++ httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en Mon Mar  5 01:41:32 2012
@@ -376,6 +376,13 @@ by many requests.
     }<br />
     </code></p></div>
 
+<div class="note"><h3>Use a RewriteLock!</h3>
+<p>When using a <code>prg:</code> RewriteMap, you should use a
+<code class="directive"><a href="../mod/mod_rewrite.html#rewritemap">RewriteMap</a></code>. Failure to do so
+will result in an error message in the log file, and may result in a
+race condition on concurrent requests.</p>
+</div>
+
 <div class="note"><h3>Caution!</h3>
 <ul>
 <li>Keep your rewrite map program as simple as possible. If the program

Modified: httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml?rev=1296931&r1=1296930&r2=1296931&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml (original)
+++ httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml Mon Mar  5 01:41:32 2012
@@ -377,6 +377,13 @@ by many requests.
     }<br />
     </example>
 
+<note><title>Use a RewriteLock!</title>
+<p>When using a <code>prg:</code> RewriteMap, you should use a
+<directive module="mod_rewrite">RewriteMap</directive>. Failure to do so
+will result in an error message in the log file, and may result in a
+race condition on concurrent requests.</p>
+</note>
+
 <note><title>Caution!</title>
 <ul>
 <li>Keep your rewrite map program as simple as possible. If the program



Re: svn commit: r1296931 - in /httpd/httpd/branches/2.2.x/docs/manual/rewrite: rewritemap.html.en rewritemap.xml

Posted by Rich Bowen <rb...@rcbowen.com>.
On Mar 4, 2012, at 9:06 PM, Rainer Jung wrote:

> Hi Rich,
> 
> On 05.03.2012 02:41, rbowen@apache.org wrote:
>> Author: rbowen
>> Date: Mon Mar  5 01:41:32 2012
>> 
>> +<div class="note"><h3>Use a RewriteLock!</h3>
>> +<p>When using a<code>prg:</code>  RewriteMap, you should use a
>> +<code class="directive"><a href="../mod/mod_rewrite.html#rewritemap">RewriteMap</a></code>. Failure to do so
> 
> RewriteLock?

Gah!

Thanks.  I got on a roll and didn't check enough. Thanks. Fixing.

--
Rich Bowen
rbowen@rcbowen.com :: @rbowen
rbowen@apache.org







Re: svn commit: r1296931 - in /httpd/httpd/branches/2.2.x/docs/manual/rewrite: rewritemap.html.en rewritemap.xml

Posted by Rich Bowen <rb...@rcbowen.com>.
On Mar 4, 2012, at 9:06 PM, Rainer Jung wrote:

> 
> Concerning 2.4+: RewriteLock was replaced by the more general "Mutex" directive. But indeed in seems in 2.2 you had to define a RewriteLock explicitely, whereas in 2.4.x one is created automatically.

Yes, I only made that change in the 2.2 docs. I suppose 2.0 needs it, too, but I've stopped doing anything with 2.0. I suppose we should probably not do that quite yet.

--
Rich Bowen
rbowen@rcbowen.com :: @rbowen
rbowen@apache.org







Re: svn commit: r1296931 - in /httpd/httpd/branches/2.2.x/docs/manual/rewrite: rewritemap.html.en rewritemap.xml

Posted by Rainer Jung <ra...@kippdata.de>.
Hi Rich,

On 05.03.2012 02:41, rbowen@apache.org wrote:
> Author: rbowen
> Date: Mon Mar  5 01:41:32 2012
> New Revision: 1296931
>
> URL: http://svn.apache.org/viewvc?rev=1296931&view=rev
> Log:
> Note that RewriteLock should be used when using prg: style RewriteMaps
> https://issues.apache.org/bugzilla/show_bug.cgi?id=52347
>
> Modified:
>      httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en
>      httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml
>
> Modified: httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en?rev=1296931&r1=1296930&r2=1296931&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en (original)
> +++ httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.html.en Mon Mar  5 01:41:32 2012
> @@ -376,6 +376,13 @@ by many requests.
>       }<br />
>       </code></p></div>
>
> +<div class="note"><h3>Use a RewriteLock!</h3>
> +<p>When using a<code>prg:</code>  RewriteMap, you should use a
> +<code class="directive"><a href="../mod/mod_rewrite.html#rewritemap">RewriteMap</a></code>. Failure to do so

RewriteLock?

> +will result in an error message in the log file, and may result in a
> +race condition on concurrent requests.</p>
> +</div>
> +
>   <div class="note"><h3>Caution!</h3>
>   <ul>
>   <li>Keep your rewrite map program as simple as possible. If the program
>
> Modified: httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml?rev=1296931&r1=1296930&r2=1296931&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml (original)
> +++ httpd/httpd/branches/2.2.x/docs/manual/rewrite/rewritemap.xml Mon Mar  5 01:41:32 2012
> @@ -377,6 +377,13 @@ by many requests.
>       }<br />
>       </example>
>
> +<note><title>Use a RewriteLock!</title>
> +<p>When using a<code>prg:</code>  RewriteMap, you should use a
> +<directive module="mod_rewrite">RewriteMap</directive>. Failure to do so

Ditto.

> +will result in an error message in the log file, and may result in a
> +race condition on concurrent requests.</p>
> +</note>
> +
>   <note><title>Caution!</title>
>   <ul>
>   <li>Keep your rewrite map program as simple as possible. If the program

Concerning 2.4+: RewriteLock was replaced by the more general "Mutex" 
directive. But indeed in seems in 2.2 you had to define a RewriteLock 
explicitely, whereas in 2.4.x one is created automatically.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org