You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by dzyangxi <gi...@git.apache.org> on 2017/06/07 09:26:30 UTC
[GitHub] incubator-rocketmq pull request #117: remove
GitHub user dzyangxi opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/117
remove
JIRA:https://issues.apache.org/jira/browse/ROCKETMQ-215?jql=project%20%3D%20ROCKETMQ
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dzyangxi/incubator-rocketmq develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 38764652b24992d839eab4c2cb50940a473e40f4
Author: yangxixi <xi...@56qq.com>
Date: 2017-06-07T08:52:11Z
remove
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/117
Hi, @dzyangxi any update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/117
[](https://coveralls.io/builds/11864245)
Coverage increased (+0.5%) to 39.145% when pulling **38764652b24992d839eab4c2cb50940a473e40f4 on dzyangxi:develop** into **80791b6deb0e5a2ab4bc920f14f3a0e786587b53 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #117: [ROCKETMQ-215]-Use java 7 syntax to re...
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120577910
--- Diff: logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java ---
@@ -39,7 +39,7 @@
public static final String DEFAULT_GROUP = "rocketmq_appender";
- private static ConcurrentHashMap<String, MQProducer> producerMap = new ConcurrentHashMap<String, MQProducer>();
--- End diff --
@dongeforever Does logappender needs to be compatible with jdk 1.6 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #117: [ROCKETMQ-215]-Use java 7 syntax to re...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120584108
--- Diff: tools/src/main/java/org/apache/rocketmq/tools/command/cluster/ClusterListSubCommand.java ---
@@ -113,7 +113,7 @@ private void printClusterMoreStats(final DefaultMQAdminExt defaultMQAdminExt) th
while (itCluster.hasNext()) {
Map.Entry<String, Set<String>> next = itCluster.next();
String clusterName = next.getKey();
- TreeSet<String> brokerNameSet = new TreeSet<String>();
--- End diff --
I think tools module should be consistent with broker module. There is no need to maintain low version compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #117: [ROCKETMQ-215]-Use java 7 syntax to re...
Posted by lindzh <gi...@git.apache.org>.
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120603647
--- Diff: logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java ---
@@ -39,7 +39,7 @@
public static final String DEFAULT_GROUP = "rocketmq_appender";
- private static ConcurrentHashMap<String, MQProducer> producerMap = new ConcurrentHashMap<String, MQProducer>();
--- End diff --
There is log4j2 implementation in logappender.Since log4j2 not supported jdk 1.6,logappender do not need to be compatible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/117
the client module and its dependencies should be compatible with 1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/117
@dongeforever it looks no changes have been made to the modules which rocketmq-client depends on.
But what I am concerned is that should rocketmq-tools needs to be compatable with 1.6 since they may possibly integrate them with their application.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #117: [ROCKETMQ-215]-Use java 7 syntax to re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/117
---
[GitHub] incubator-rocketmq pull request #117: [ROCKETMQ-215]-Use java 7 syntax to re...
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120577661
--- Diff: tools/src/main/java/org/apache/rocketmq/tools/command/cluster/ClusterListSubCommand.java ---
@@ -113,7 +113,7 @@ private void printClusterMoreStats(final DefaultMQAdminExt defaultMQAdminExt) th
while (itCluster.hasNext()) {
Map.Entry<String, Set<String>> next = itCluster.next();
String clusterName = next.getKey();
- TreeSet<String> brokerNameSet = new TreeSet<String>();
--- End diff --
@dongeforever
Do we still need to make rocketmq-tools be compatible with jdk1.6? If yes, we can not do the changes in rocketmq-tools module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---