You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/03/16 16:33:14 UTC
[GitHub] [hive] deniskuzZ opened a new pull request #3111: Non-blocking materialized view drop
deniskuzZ opened a new pull request #3111:
URL: https://github.com/apache/hive/pull/3111
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #3111: HIVE-26052: Non blocking DROP MATERIALIZED VIEW implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #3111:
URL: https://github.com/apache/hive/pull/3111#discussion_r832155994
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -1768,4 +1768,97 @@ public void testDropTableWithoutSuffix() throws Exception {
Assert.assertEquals("Unexpected number of compactions in history", 0, resp.getCompactsSize());
}
}
+
+ @Test
+ public void testDropMaterializedViewWithSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+ runStatementOnDriver("drop table if exists " + tableName);
+ HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX, true);
+
+ runStatementOnDriver("create table " + tableName + "(a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')");
+ runStatementOnDriver("insert into " + tableName + " values(1,2),(3,4)");
+ runStatementOnDriver("create materialized view " + mviewName + " stored as orc TBLPROPERTIES ('transactional'='true') " +
+ "as select a from tab_acid where b > 1");
+ runStatementOnDriver("drop materialized view " + mviewName);
+
+ int count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(1, count);
+
+ FileSystem fs = FileSystem.get(hiveConf);
+ FileStatus[] stat = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ if (1 != stat.length) {
+ Assert.fail("Materialized view data was removed from FS");
+ }
+ MetastoreTaskThread houseKeeperService = new AcidHouseKeeperService();
+ houseKeeperService.setConf(hiveConf);
+
+ houseKeeperService.run();
+ count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(0, count);
+
+ try {
+ runStatementOnDriver("select * from " + mviewName);
+ } catch (Exception ex) {
+ Assert.assertTrue(ex.getMessage().contains(
+ ErrorMsg.INVALID_TABLE.getMsg(StringUtils.wrap(mviewName, "'"))));
+ }
+ // Check status of compaction job
+ TxnStore txnHandler = TxnUtils.getTxnStore(hiveConf);
+ ShowCompactResponse resp = txnHandler.showCompact(new ShowCompactRequest());
+
+ Assert.assertEquals("Unexpected number of compactions in history", 1, resp.getCompactsSize());
+ Assert.assertEquals("Unexpected 0 compaction state",
+ TxnStore.CLEANING_RESPONSE, resp.getCompacts().get(0).getState());
+
+ runCleaner(hiveConf);
+
+ FileStatus[] status = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ Assert.assertEquals(0, status.length);
+ }
+
+ @Test
+ public void testDropMaterializedViewWithoutSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+
+ for (boolean enabled : Arrays.asList( true)) {
Review comment:
yes, you're right, looks like I removed 1 of the combinations during the troubleshooting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #3111: Non-blocking materialized view drop
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #3111:
URL: https://github.com/apache/hive/pull/3111#discussion_r830767871
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -1768,4 +1768,97 @@ public void testDropTableWithoutSuffix() throws Exception {
Assert.assertEquals("Unexpected number of compactions in history", 0, resp.getCompactsSize());
}
}
+
+ @Test
+ public void testDropMaterializedViewWithSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+ runStatementOnDriver("drop table if exists " + tableName);
+ HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX, true);
+
+ runStatementOnDriver("create table " + tableName + "(a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')");
+ runStatementOnDriver("insert into " + tableName + " values(1,2),(3,4)");
+ runStatementOnDriver("create materialized view " + mviewName + " stored as orc TBLPROPERTIES ('transactional'='true') " +
+ "as select a from tab_acid where b > 1");
+ runStatementOnDriver("drop materialized view " + mviewName);
+
+ int count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(1, count);
+
+ FileSystem fs = FileSystem.get(hiveConf);
+ FileStatus[] stat = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ if (1 != stat.length) {
+ Assert.fail("Materialized view data was removed from FS");
+ }
+ MetastoreTaskThread houseKeeperService = new AcidHouseKeeperService();
+ houseKeeperService.setConf(hiveConf);
+
+ houseKeeperService.run();
+ count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(0, count);
+
+ try {
+ runStatementOnDriver("select * from " + mviewName);
+ } catch (Exception ex) {
+ Assert.assertTrue(ex.getMessage().contains(
+ ErrorMsg.INVALID_TABLE.getMsg(StringUtils.wrap(mviewName, "'"))));
+ }
+ // Check status of compaction job
+ TxnStore txnHandler = TxnUtils.getTxnStore(hiveConf);
+ ShowCompactResponse resp = txnHandler.showCompact(new ShowCompactRequest());
+
+ Assert.assertEquals("Unexpected number of compactions in history", 1, resp.getCompactsSize());
+ Assert.assertEquals("Unexpected 0 compaction state",
+ TxnStore.CLEANING_RESPONSE, resp.getCompacts().get(0).getState());
+
+ runCleaner(hiveConf);
+
+ FileStatus[] status = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ Assert.assertEquals(0, status.length);
+ }
+
+ @Test
+ public void testDropMaterializedViewWithoutSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+
+ for (boolean enabled : Arrays.asList( true)) {
Review comment:
What is the purpose of this for loop?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/drop/DropMaterializedViewAnalyzer.java
##########
@@ -50,7 +54,14 @@ public void analyzeInternal(ASTNode root) throws SemanticException {
Table materializedView = getTable(viewName, throwException);
if (materializedView != null) {
inputs.add(new ReadEntity(materializedView));
- outputs.add(new WriteEntity(materializedView, WriteEntity.WriteType.DDL_EXCLUSIVE));
+
+ boolean tableWithSuffix = (HiveConf.getBoolVar(conf, ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX)
+ || HiveConf.getBoolVar(conf, ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))
+ && AcidUtils.isTransactionalTable(materializedView)
+ && Boolean.parseBoolean(materializedView.getProperty(SOFT_DELETE_TABLE));
+
+ outputs.add(new WriteEntity(materializedView,
+ tableWithSuffix ? WriteType.DDL_EXCL_WRITE : WriteType.DDL_EXCLUSIVE));
Review comment:
I found that this piece of code is also present in `DropTableAnalyzer`
https://github.com/apache/hive/blob/cba74fa91d4035aee2c39dcf929a0ae480609540/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/DropTableAnalyzer.java#L59
Could you please try reusing it? Like extracting it into some utility class or into the common super class `BaseSemanticAnalyzer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #3111: HIVE-26052: Non blocking DROP MATERIALIZED VIEW implementation
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #3111:
URL: https://github.com/apache/hive/pull/3111#discussion_r830958725
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -1768,4 +1768,97 @@ public void testDropTableWithoutSuffix() throws Exception {
Assert.assertEquals("Unexpected number of compactions in history", 0, resp.getCompactsSize());
}
}
+
+ @Test
+ public void testDropMaterializedViewWithSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+ runStatementOnDriver("drop table if exists " + tableName);
+ HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX, true);
+
+ runStatementOnDriver("create table " + tableName + "(a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')");
+ runStatementOnDriver("insert into " + tableName + " values(1,2),(3,4)");
+ runStatementOnDriver("create materialized view " + mviewName + " stored as orc TBLPROPERTIES ('transactional'='true') " +
+ "as select a from tab_acid where b > 1");
+ runStatementOnDriver("drop materialized view " + mviewName);
+
+ int count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(1, count);
+
+ FileSystem fs = FileSystem.get(hiveConf);
+ FileStatus[] stat = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ if (1 != stat.length) {
+ Assert.fail("Materialized view data was removed from FS");
+ }
+ MetastoreTaskThread houseKeeperService = new AcidHouseKeeperService();
+ houseKeeperService.setConf(hiveConf);
+
+ houseKeeperService.run();
+ count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(0, count);
+
+ try {
+ runStatementOnDriver("select * from " + mviewName);
+ } catch (Exception ex) {
+ Assert.assertTrue(ex.getMessage().contains(
+ ErrorMsg.INVALID_TABLE.getMsg(StringUtils.wrap(mviewName, "'"))));
+ }
+ // Check status of compaction job
+ TxnStore txnHandler = TxnUtils.getTxnStore(hiveConf);
+ ShowCompactResponse resp = txnHandler.showCompact(new ShowCompactRequest());
+
+ Assert.assertEquals("Unexpected number of compactions in history", 1, resp.getCompactsSize());
+ Assert.assertEquals("Unexpected 0 compaction state",
+ TxnStore.CLEANING_RESPONSE, resp.getCompacts().get(0).getState());
+
+ runCleaner(hiveConf);
+
+ FileStatus[] status = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ Assert.assertEquals(0, status.length);
+ }
+
+ @Test
+ public void testDropMaterializedViewWithoutSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+
+ for (boolean enabled : Arrays.asList( true)) {
Review comment:
Maybe I'm missing something bit it seems that it checks only one of the combinations
```
Arrays.asList( true)
```
To check both combinations I would expect
```
Arrays.asList(true, false)
```
Personally I would create 2 separate tests named exactly what the test does and a method with the common parts instead of the for loop. Like you did later:
```
@Test
public void testDropMaterializedViewNonBlocking() throws Exception {
testDropMaterializedView(false);
}
@Test
public void testDropMaterializedViewBlocking() throws Exception {
testDropMaterializedView(true);
}
private void testDropMaterializedView(boolean blocking) throws Exception {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #3111: HIVE-26052: Non blocking DROP MATERIALIZED VIEW implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #3111:
URL: https://github.com/apache/hive/pull/3111#discussion_r830880753
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -1768,4 +1768,97 @@ public void testDropTableWithoutSuffix() throws Exception {
Assert.assertEquals("Unexpected number of compactions in history", 0, resp.getCompactsSize());
}
}
+
+ @Test
+ public void testDropMaterializedViewWithSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+ runStatementOnDriver("drop table if exists " + tableName);
+ HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX, true);
+
+ runStatementOnDriver("create table " + tableName + "(a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')");
+ runStatementOnDriver("insert into " + tableName + " values(1,2),(3,4)");
+ runStatementOnDriver("create materialized view " + mviewName + " stored as orc TBLPROPERTIES ('transactional'='true') " +
+ "as select a from tab_acid where b > 1");
+ runStatementOnDriver("drop materialized view " + mviewName);
+
+ int count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(1, count);
+
+ FileSystem fs = FileSystem.get(hiveConf);
+ FileStatus[] stat = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ if (1 != stat.length) {
+ Assert.fail("Materialized view data was removed from FS");
+ }
+ MetastoreTaskThread houseKeeperService = new AcidHouseKeeperService();
+ houseKeeperService.setConf(hiveConf);
+
+ houseKeeperService.run();
+ count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(0, count);
+
+ try {
+ runStatementOnDriver("select * from " + mviewName);
+ } catch (Exception ex) {
+ Assert.assertTrue(ex.getMessage().contains(
+ ErrorMsg.INVALID_TABLE.getMsg(StringUtils.wrap(mviewName, "'"))));
+ }
+ // Check status of compaction job
+ TxnStore txnHandler = TxnUtils.getTxnStore(hiveConf);
+ ShowCompactResponse resp = txnHandler.showCompact(new ShowCompactRequest());
+
+ Assert.assertEquals("Unexpected number of compactions in history", 1, resp.getCompactsSize());
+ Assert.assertEquals("Unexpected 0 compaction state",
+ TxnStore.CLEANING_RESPONSE, resp.getCompacts().get(0).getState());
+
+ runCleaner(hiveConf);
+
+ FileStatus[] status = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ Assert.assertEquals(0, status.length);
+ }
+
+ @Test
+ public void testDropMaterializedViewWithoutSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+
+ for (boolean enabled : Arrays.asList( true)) {
Review comment:
checks 2 combinations when MV was created with flag on/off and drop was called with opposite values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ closed pull request #3111: HIVE-26052: Non blocking DROP MATERIALIZED VIEW implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ closed pull request #3111:
URL: https://github.com/apache/hive/pull/3111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #3111: HIVE-26052: Non blocking DROP MATERIALIZED VIEW implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #3111:
URL: https://github.com/apache/hive/pull/3111#discussion_r830891092
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/drop/DropMaterializedViewAnalyzer.java
##########
@@ -50,7 +54,14 @@ public void analyzeInternal(ASTNode root) throws SemanticException {
Table materializedView = getTable(viewName, throwException);
if (materializedView != null) {
inputs.add(new ReadEntity(materializedView));
- outputs.add(new WriteEntity(materializedView, WriteEntity.WriteType.DDL_EXCLUSIVE));
+
+ boolean tableWithSuffix = (HiveConf.getBoolVar(conf, ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX)
+ || HiveConf.getBoolVar(conf, ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))
+ && AcidUtils.isTransactionalTable(materializedView)
+ && Boolean.parseBoolean(materializedView.getProperty(SOFT_DELETE_TABLE));
+
+ outputs.add(new WriteEntity(materializedView,
+ tableWithSuffix ? WriteType.DDL_EXCL_WRITE : WriteType.DDL_EXCLUSIVE));
Review comment:
refactored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #3111: HIVE-26052: Non blocking DROP MATERIALIZED VIEW implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #3111:
URL: https://github.com/apache/hive/pull/3111#discussion_r830880753
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -1768,4 +1768,97 @@ public void testDropTableWithoutSuffix() throws Exception {
Assert.assertEquals("Unexpected number of compactions in history", 0, resp.getCompactsSize());
}
}
+
+ @Test
+ public void testDropMaterializedViewWithSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+ runStatementOnDriver("drop table if exists " + tableName);
+ HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX, true);
+
+ runStatementOnDriver("create table " + tableName + "(a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')");
+ runStatementOnDriver("insert into " + tableName + " values(1,2),(3,4)");
+ runStatementOnDriver("create materialized view " + mviewName + " stored as orc TBLPROPERTIES ('transactional'='true') " +
+ "as select a from tab_acid where b > 1");
+ runStatementOnDriver("drop materialized view " + mviewName);
+
+ int count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(1, count);
+
+ FileSystem fs = FileSystem.get(hiveConf);
+ FileStatus[] stat = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ if (1 != stat.length) {
+ Assert.fail("Materialized view data was removed from FS");
+ }
+ MetastoreTaskThread houseKeeperService = new AcidHouseKeeperService();
+ houseKeeperService.setConf(hiveConf);
+
+ houseKeeperService.run();
+ count = TestTxnDbUtil.countQueryAgent(hiveConf,
+ "select count(*) from TXN_TO_WRITE_ID where T2W_TABLE = '" + mviewName + "'");
+ Assert.assertEquals(0, count);
+
+ try {
+ runStatementOnDriver("select * from " + mviewName);
+ } catch (Exception ex) {
+ Assert.assertTrue(ex.getMessage().contains(
+ ErrorMsg.INVALID_TABLE.getMsg(StringUtils.wrap(mviewName, "'"))));
+ }
+ // Check status of compaction job
+ TxnStore txnHandler = TxnUtils.getTxnStore(hiveConf);
+ ShowCompactResponse resp = txnHandler.showCompact(new ShowCompactRequest());
+
+ Assert.assertEquals("Unexpected number of compactions in history", 1, resp.getCompactsSize());
+ Assert.assertEquals("Unexpected 0 compaction state",
+ TxnStore.CLEANING_RESPONSE, resp.getCompacts().get(0).getState());
+
+ runCleaner(hiveConf);
+
+ FileStatus[] status = fs.listStatus(new Path(getWarehouseDir()),
+ t -> t.getName().matches(mviewName + SOFT_DELETE_TABLE_PATTERN));
+ Assert.assertEquals(0, status.length);
+ }
+
+ @Test
+ public void testDropMaterializedViewWithoutSuffix() throws Exception {
+ String tableName = "tab_acid";
+ String mviewName = "mv_" + tableName;
+ runStatementOnDriver("drop materialized view if exists " + mviewName);
+
+ for (boolean enabled : Arrays.asList( true)) {
Review comment:
check 2 combinations when MV was created with flag on/off and drop was called with opposite values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org