You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/08/24 07:44:33 UTC
[GitHub] tajo pull request: Check ON_ERROR_STOP flag in TSQL when error is ...
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/708
Check ON_ERROR_STOP flag in TSQL when error is occured
Since the bug tsql suicide itself by any error, check the ON_ERROR_STOP. If it is TRUE, TSQL quit itself with exitcode returned.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/708.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #708
----
commit 76f92caabc7df786d0ec146dcc1a390207aa2c7d
Author: Dongkyu Hwangbo <dk...@gruter.com>
Date: 2015-08-24T05:38:16Z
if at least one failed, check ON_ERROR_STOP flag
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Check ON_ERROR_STOP flag in TSQL when error is ...
Posted by dkhwangbo <gi...@git.apache.org>.
GitHub user dkhwangbo reopened a pull request:
https://github.com/apache/tajo/pull/708
Check ON_ERROR_STOP flag in TSQL when error is occured
Since the bug tsql suicide itself by any error, check the ON_ERROR_STOP. If it is TRUE, TSQL quit itself with exitcode returned.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/708.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #708
----
commit 76f92caabc7df786d0ec146dcc1a390207aa2c7d
Author: Dongkyu Hwangbo <dk...@gruter.com>
Date: 2015-08-24T05:38:16Z
if at least one failed, check ON_ERROR_STOP flag
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Check ON_ERROR_STOP flag in TSQL when error is ...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo closed the pull request at:
https://github.com/apache/tajo/pull/708
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1782: Check ON_ERROR_STOP flag in TSQL whe...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/708#issuecomment-134224201
Looks good to me.
@hyunsik, would you mind reviewing this patch? It looks to be related to your recent patches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1782: Check ON_ERROR_STOP flag in TSQL whe...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo closed the pull request at:
https://github.com/apache/tajo/pull/708
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1782: Check ON_ERROR_STOP flag in TSQL whe...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/708#issuecomment-134870293
The patch looks good to me. If possible, could you add some unit tests to guarantee the bug fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---