You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/01/30 14:08:10 UTC
[GitHub] flink pull request #5384: [FLINK-8475][config][docs] Integrate akka options
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5384
[FLINK-8475][config][docs] Integrate akka options
## What is the purpose of the change
This PR integrates the Akka `ConfigOptions` into the configuration docs generator.
## Brief change log
* Add missing descriptions to config options (derived from existing description/javadocs)
* integrate akka configuration table into `config.md`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8475_akka
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5384
----
commit f61db3f46ca83913be3eaa9b2d04c4b25eb9e2cc
Author: zentol <ch...@...>
Date: 2018-01-22T15:29:55Z
[FLINK-8475][config][docs] Integrate akka options
----
---
[GitHub] flink issue #5384: [FLINK-8475][config][docs] Integrate akka options
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5384
More reason for the more advanced configuration stuff where you can actually specify such things directly in the configuration code. 😅
Changes look good now, though. 👍
---
[GitHub] flink issue #5384: [FLINK-8475][config][docs] Integrate akka options
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
Note that the existing docs were wrong regardless, see AkkaUtils:
```
val startupTimeout = configuration.getString(
AkkaOptions.STARTUP_TIMEOUT,
(akkaAskTimeout * 10).toString)
```
---
[GitHub] flink pull request #5384: [FLINK-8475][config][docs] Integrate akka options
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5384
---
[GitHub] flink issue #5384: [FLINK-8475][config][docs] Integrate akka options
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
akka.startup-timeout has no default value because that's how the ConfigOption is actually defined; in other words ATM we can't guarantee anything about the default.
---
[GitHub] flink issue #5384: [FLINK-8475][config][docs] Integrate akka options
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5384
The changes look good but I noticed some weirdness:
- `akka.client.timeout` doesn't have a description now but it did have one earlier
- `akka.startup-timeout` has `(none)` as default while it had `akka.ask.timeout` previously
---
[GitHub] flink issue #5384: [FLINK-8475][config][docs] Integrate akka options
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
merging.
---
[GitHub] flink issue #5384: [FLINK-8475][config][docs] Integrate akka options
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
@aljoscha Fixed.
---