[GitHub] [lucene-solr] dsmiley commented on pull request #1972: SOLR-14915: Prometheus-exporter does not depend on Solr-core any longer

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #1972:
URL: https://github.com/apache/lucene-solr/pull/1972#issuecomment-727526911


   Based on your advise, I put back the "java-library" plugin in place of the application one, but added a "run" task.
   
   The prometheus-exporter is fundamentally dissimilar to the other contribs.  The others have Solr plugins -- they run *inside* Solr, and thus don't need "lib" directories containing any of the libs that are in Solr.  But I don't think the prometheus-exporter should have such a limited list.  I see `gradle/solr/packaging.gradle` and it treats all contribs as the same.  So I added more assemblePackage code here that ends up adding other libs like jackson because it does not exclude all so-called "Solr platform libs".   Also, I ensured all server/lib/ext JARs (which are all logging) don't get copied to any contrib's libs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org