You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by "Knut Urdalen (JIRA)" <ji...@apache.org> on 2009/05/02 09:33:35 UTC

[jira] Created: (LOG4PHP-34) Remove all internal debugging

Remove all internal debugging
-----------------------------

                 Key: LOG4PHP-34
                 URL: https://issues.apache.org/jira/browse/LOG4PHP-34
             Project: Log4php
          Issue Type: Improvement
          Components: Code
            Reporter: Knut Urdalen
            Assignee: Knut Urdalen
            Priority: Minor
             Fix For: 2.0


I suggest that we remove all internal debugging in the code base. We currently have 117 places where we do LoggerLog::debug(). These are all unnecessary method calls that a lightweight logging framework can do without. Xdebug strack trace and profiling is a better option for debugging and understand the execution of log4php instead of pollute the code with internal debug statements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Created: (LOG4PHP-34) Remove all internal debugging

Posted by Christian Grobmeier <gr...@gmail.com>.
> I suggest that we remove all internal debugging in the code base. We currently have 117 places where we do LoggerLog::debug(). These are all unnecessary method calls that a lightweight logging framework can do without. Xdebug strack trace and profiling is a better option for debugging and understand the execution of log4php instead of pollute the code with internal debug statements.

+1 - even when xdebug is not running at my boxes till now :-)
Cheers
Christian

[jira] Resolved: (LOG4PHP-34) Remove all internal debugging

Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LOG4PHP-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Grobmeier resolved LOG4PHP-34.
----------------------------------------

    Resolution: Fixed

Everything removed

> Remove all internal debugging
> -----------------------------
>
>                 Key: LOG4PHP-34
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-34
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>            Reporter: Knut Urdalen
>            Assignee: Knut Urdalen
>            Priority: Minor
>             Fix For: 2.0
>
>
> I suggest that we remove all internal debugging in the code base. We currently have 117 places where we do LoggerLog::debug(). These are all unnecessary method calls that a lightweight logging framework can do without. Xdebug strack trace and profiling is a better option for debugging and understand the execution of log4php instead of pollute the code with internal debug statements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (LOG4PHP-34) Remove all internal debugging

Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LOG4PHP-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705492#action_12705492 ] 

Christian Grobmeier commented on LOG4PHP-34:
--------------------------------------------

removed method calls to LoggerLog.
Still todo:
- Remove LoggerLog class
- Remove LoggerLotTest class
- Clean up xml/dtd stuff for LoggerLog, if appropriate

> Remove all internal debugging
> -----------------------------
>
>                 Key: LOG4PHP-34
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-34
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>            Reporter: Knut Urdalen
>            Assignee: Knut Urdalen
>            Priority: Minor
>             Fix For: 2.0
>
>
> I suggest that we remove all internal debugging in the code base. We currently have 117 places where we do LoggerLog::debug(). These are all unnecessary method calls that a lightweight logging framework can do without. Xdebug strack trace and profiling is a better option for debugging and understand the execution of log4php instead of pollute the code with internal debug statements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.