You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2019/01/29 05:46:37 UTC

[jclouds/jclouds] Lazily open InputStream during complete MPU (#1269)

Previously the filesystem provider could exhaust file descriptors by
eagerly opening up to 10,000 parts.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1269

-- Commit Summary --

  * Lazily open InputStream during complete MPU

-- File Changes --

    M blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java (50)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1269.patch
https://github.com/jclouds/jclouds/pull/1269.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1269

Re: [jclouds/jclouds] Lazily open InputStream during complete MPU (#1269)

Posted by Andrew Phillips <no...@github.com>.

Is there anything about this change that would merit a test? I'm assuming "does not open tons of file descriptors" is not something that's easy/feasible to test for..?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1269#issuecomment-458521805

Re: [jclouds/jclouds] Lazily open InputStream during complete MPU (#1269)

Posted by Andrew Gaul <no...@github.com>.

@timuralp could you review this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1269#issuecomment-458415594

Re: [jclouds/jclouds] Lazily open InputStream during complete MPU (#1269)

Posted by Timur Alperovich <no...@github.com>.

timuralp approved this pull request.

Looks good to me!



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1269#pullrequestreview-197776920

Re: [jclouds/jclouds] Lazily open InputStream during complete MPU (#1269)

Posted by Andrew Gaul <no...@github.com>.

> Is there anything about this change that would merit a test? I'm assuming "does not open tons of file descriptors" is not something that's easy/feasible to test for..?

Indeed this commit was ineffective due to JCLOUDS-1367.  I added a test and fixed the other issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1269#issuecomment-458789099