You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/01 19:24:18 UTC
Review Request 26233: Add a monitoring guide.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-634
https://issues.apache.org/jira/browse/AURORA-634
Repository: aurora
Description
-------
Add a monitoring guide.
Diffs
-----
docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
docs/monitoring.md PRE-CREATION
Diff: https://reviews.apache.org/r/26233/diff/
Testing
-------
Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
Thanks,
Bill Farner
Re: Review Request 26233: Add a monitoring guide.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55107
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 1, 2014, 5:56 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 5:56 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a monitoring guide.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26233/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
>
> I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26233: Add a monitoring guide.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/
-----------------------------------------------------------
(Updated Oct. 1, 2014, 5:56 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-634
https://issues.apache.org/jira/browse/AURORA-634
Repository: aurora
Description
-------
Add a monitoring guide.
Diffs (updated)
-----
docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
docs/monitoring.md PRE-CREATION
Diff: https://reviews.apache.org/r/26233/diff/
Testing
-------
Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
Thanks,
Bill Farner
Re: Review Request 26233: Add a monitoring guide.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55091
-----------------------------------------------------------
Ship it!
Wow.
- Joe Smith
On Oct. 1, 2014, 10:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 10:27 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a monitoring guide.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26233/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
>
> I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26233: Add a monitoring guide.
Posted by Bill Farner <wf...@apache.org>.
> On Oct. 1, 2014, 5:41 p.m., Kevin Sweeney wrote:
> > docs/monitoring.md, line 184
> > <https://reviews.apache.org/r/26233/diff/2/?file=710149#file710149line184>
> >
> > style point: we've rendered command-line flags with a single dash in other documentation. Though both are acceptable it would be good to internally standardize on one style.
Thanks, this isn't even a style point as much as a bad doc. The command line parser requires a single dash here. Fixed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55089
-----------------------------------------------------------
On Oct. 1, 2014, 5:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 5:27 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a monitoring guide.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26233/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
>
> I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26233: Add a monitoring guide.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Oct. 1, 2014, 10:41 a.m., Kevin Sweeney wrote:
> > docs/monitoring.md, line 184
> > <https://reviews.apache.org/r/26233/diff/2/?file=710149#file710149line184>
> >
> > style point: we've rendered command-line flags with a single dash in other documentation. Though both are acceptable it would be good to internally standardize on one style.
>
> Bill Farner wrote:
> Thanks, this isn't even a style point as much as a bad doc. The command line parser requires a single dash here. Fixed.
aha, tmyk
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55089
-----------------------------------------------------------
On Oct. 1, 2014, 10:56 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 10:56 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a monitoring guide.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26233/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
>
> I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26233: Add a monitoring guide.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55089
-----------------------------------------------------------
Ship it!
docs/monitoring.md
<https://reviews.apache.org/r/26233/#comment95453>
style point: we've rendered command-line flags with a single dash in other documentation. Though both are acceptable it would be good to internally standardize on one style.
- Kevin Sweeney
On Oct. 1, 2014, 10:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 10:27 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a monitoring guide.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26233/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
>
> I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26233: Add a monitoring guide.
Posted by Bill Farner <wf...@apache.org>.
> On Oct. 1, 2014, 5:43 p.m., Maxim Khutornenko wrote:
> > Would it make sense to wrap alerts into a table? E.g.:
> >
> > Name | Type | Description | Alerting | Triage
> > -----|------|-------------|----------|--------
The thought crossed my mind, but i don't really like using tables where the content is arbitrarily-long prose. I think it makes the markdown much more difficult to edit and read without rendering.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55090
-----------------------------------------------------------
On Oct. 1, 2014, 5:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 5:27 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a monitoring guide.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26233/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
>
> I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26233: Add a monitoring guide.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55090
-----------------------------------------------------------
Would it make sense to wrap alerts into a table? E.g.:
Name | Type | Description | Alerting | Triage
-----|------|-------------|----------|--------
- Maxim Khutornenko
On Oct. 1, 2014, 5:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 5:27 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a monitoring guide.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26233/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
>
> I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26233: Add a monitoring guide.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/
-----------------------------------------------------------
(Updated Oct. 1, 2014, 5:27 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Added note about 500s.
Bugs: AURORA-634
https://issues.apache.org/jira/browse/AURORA-634
Repository: aurora
Description
-------
Add a monitoring guide.
Diffs (updated)
-----
docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176
docs/monitoring.md PRE-CREATION
Diff: https://reviews.apache.org/r/26233/diff/
Testing
-------
Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion.
Thanks,
Bill Farner