You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "poorbarcode (via GitHub)" <gi...@apache.org> on 2025/10/21 14:30:17 UTC

[PR] [fix][broker]Stop to retry to read entries if the replicator has terminated [pulsar]

poorbarcode opened a new pull request, #24880:
URL: https://github.com/apache/pulsar/pull/24880

   ### Motivation
   
   If a scheduled replication reading task is waiting to be executed<sup>[1]> when a geo replicator is terminating, it will keep retrying to read entries.
   
   **[1]**: a scheduled replication reading task is waiting to be executed
   - https://github.com/apache/pulsar/blob/v4.1.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java#L290-L291
   
   ```java
       protected void readMoreEntries() {
           if (!hasPendingRead()) {
               // Replicator may leave a delayed task here when it is terminating
               topic.getBrokerService().executor().schedule(
                       () -> readMoreEntries(), MESSAGE_RATE_BACKOFF_MS, TimeUnit.MILLISECONDS);
               return;
           } 
   }
   ```
   
   ### Modifications
   
   Stop trying to read entries if a replicator has terminated
   
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: x
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker]Stop to retry to read entries if the replicator has terminated [pulsar]

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #24880:
URL: https://github.com/apache/pulsar/pull/24880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker]Stop to retry to read entries if the replicator has terminated [pulsar]

Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #24880:
URL: https://github.com/apache/pulsar/pull/24880#issuecomment-3430238704

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker]Stop to retry to read entries if the replicator has terminated [pulsar]

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #24880:
URL: https://github.com/apache/pulsar/pull/24880#issuecomment-3440822054

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org