[GitHub] [superset] justinpark commented on a diff in pull request #25088: chore: consolidate sqllab store into SPA store

["justinpark (via GitHub)" <gi...@apache.org>]

justinpark commented on code in PR #25088:
URL: https://github.com/apache/superset/pull/25088#discussion_r1306208225


##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -136,8 +139,23 @@ export function getUpToDateQuery(rootState, queryEditor, key) {
   };
 }
 
-export function resetState() {
-  return { type: RESET_STATE };
+export function resetState(data) {
+  return (dispatch, getState) => {
+    const { common, user, config } = getState();
+    const initialState = getInitialState({

Review Comment:
   good point. I don't like to pass these but sqllab initial logic requires `common`. let me pass this value (common) only



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org