[GitHub] michael-o commented on a change in pull request #2: MSKINS-143: Allow setting GA options for forceSSL and anonymizeIP

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #2: MSKINS-143: Allow setting GA options for forceSSL and anonymizeIP
URL: https://github.com/apache/maven-fluido-skin/pull/2#discussion_r192585491
 
 

 ##########
 File path: src/site/apt/index.apt.vm
 ##########
 @@ -166,6 +166,37 @@ Welcome to ${project.name}!
 </project>
 +-----+
 
+** GoogleAnalytics
+
+ Users can optionally enable <<Google Analytics>> for the generated site:
+
++-----+
+<project name="xxx">
+  [...]
+  <googleAnalytics>UA-12345...</googleAnalytics>
+  [...]
+</project>
++-----+
+
+It is also possible to enable the options to force SSL or anonymize the IP address:
 
 Review comment:
   This does not make any sense now because it is on by default. Can you reword, e,g, both are on by default and it is recommended not to change...?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services