You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/09 16:09:50 UTC

[GitHub] [commons-net] payal-meh commented on a change in pull request #65: NET-690 Performance issue when using the FTPClient to retrieve files …

payal-meh commented on a change in pull request #65:
URL: https://github.com/apache/commons-net/pull/65#discussion_r502533767



##########
File path: src/main/java/org/apache/commons/net/ftp/FTPClient.java
##########
@@ -1917,6 +1917,7 @@ protected boolean _retrieveFile(final String command, final String remote, final
             Util.copyStream(input, local, getBufferSize(),
                     CopyStreamEvent.UNKNOWN_STREAM_SIZE, mergeListeners(csl),
                     false);
+            input.close();

Review comment:
       It looks like the inputstream needs to be closed before trying to get the transfer response. 
   When I stepped through the debugger would hang on FTP.__getReply line 320
   `        String line = _controlInput_.readLine();`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org