You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/01/26 23:02:30 UTC
[GitHub] [hop] pscigala opened a new pull request #1298: Hop 3606 Disabled java 11 tests
pscigala opened a new pull request #1298:
URL: https://github.com/apache/hop/pull/1298
Resolves problems with some of ignored tests. Most common case is connected with new mockito argument matchers api which does not allow passing null values anymore using anyType() methods. E.g. anyString() could be replaced with nullable(String.class).
Also fixes problems with javassist incompatibility
Each specific case is described by single dedicated commit.
- Fixed mockito matchers, mostly by providing nullable(Class) instead 'anyType' which does not respect argument values anymore. Resolves issues:
HOP-3607, HOP-3608, HOP-3609, HOP-3610, HOP-3611, HOP-3614, HOP-3612, HOP-3624, HOP-3625, HOP-3646, HOP-3626, HOP-3630, HOP-3632, HOP-3631, HOP-3638, HOP-3639, HOP-3640, HOP-3644, HOP-3646, HOP-3649
- Powermock upgrade Resolves:
HOP-3648
- Upgraded Javassist for Powermock compatibility Resolves:
HOP-3637, HOP-3636, HOP-3635, HOP-3634
- Added MockitoJUnitRunner Resolves:
HOP-3627, HOP-3628
- Already working tests, removed ignore annotation Resolves:
HOP-3615, HOP-3616, HOP-3617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pscigala edited a comment on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
pscigala edited a comment on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1024866656
@gvdutra thank you i reported a bug and separate PR for that that as You suggested
https://github.com/apache/hop/pull/1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pscigala commented on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
pscigala commented on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1024866656
@gvdutra thank you i reported a bug and separate PR for that that as u suggested
https://github.com/apache/hop/pull/1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1298:
URL: https://github.com/apache/hop/pull/1298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] gvdutra commented on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
gvdutra commented on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1023267987
I would go with the flag for now, however, keep in mind this will create one dependency when we upgrade hop to java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pscigala commented on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
pscigala commented on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1023729719
After investigation build failure reason seems that '-illegal-access=permit' defined already in root pom.xml seems to work well and causes exactly that 'error' like warning which is not real build failure cause.
The real cause is in hop-transform-checksum CheckSumMetaTest.testSerialization
```
...
[ERROR] Tests run: 4, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 5.091 s <<< FAILURE! - in org.apache.hop.pipeline.transforms.checksum.CheckSumMetaTest
...
'Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project hop-transform-checksum: There are test failures. '
```
The test was not marked as @Ignored before.
At first glance the test runs well on local machine. But then I tried to run it multiple times and it started failing after few repeats in a non deterministic way. Maybe case this needs separate bugfix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1023109775
for now I would go for the flag, we can take a look at a later stage to get these warnings gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pscigala commented on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
pscigala commented on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1023054821
Seems that builds are failing because of an "An illegal reflective access" warnings.
This is common case when using things like powermock and reflective manipulation libraries in java 11 and above.
The question is - is it will be good enough to use "--illegal-access=permit/warn" flag in surefire plugin?
Or should we rather try to find another way to solve the problem with mocking/reflective manipulation libraries (probably will require much more refactoring)?
The first path could fit well in java-11 release. However, in java-17 the flag is removed and "--add-opens" seems to replace the behaviour but requires providing explicitly in argument which packages are opened for manipulation.
Surprisingly at the moment "--illegal-access=permit" is used by surefire plugin in root pom.xml, but seems to not work for submodules during github build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1024889932
Thank you so much for this PR @pscigala !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] gvdutra commented on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
gvdutra commented on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1023850082
Hi, thanks for all your commits :). I would say if this is a test that was failing before, separate the PR into two.... commit what u have fixed so far, and another one for the remaining...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pscigala edited a comment on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
pscigala edited a comment on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1024866656
@gvdutra thank you i reported a bug and separate PR for that that as you suggested
https://github.com/apache/hop/pull/1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pscigala edited a comment on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
pscigala edited a comment on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1023729719
After investigation build failure reason seems that '-illegal-access=permit' defined already in root pom.xml seems to work well and causes exactly that 'error' like warning which is not real build failure cause.
The real cause is in hop-transform-checksum CheckSumMetaTest.testSerialization
```
...
[ERROR] Tests run: 4, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 5.091 s <<< FAILURE! - in org.apache.hop.pipeline.transforms.checksum.CheckSumMetaTest
...
'Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project hop-transform-checksum: There are test failures. '
```
The test was not marked as @Ignored before.
At first glance the test runs well on local machine. But then I tried to run it multiple times and it started failing after few repeats in a non deterministic way. Maybe this case needs separate bugfix?
Example fail stack from local machine:
```
java.lang.RuntimeException: Error validating checkSumType
at org.apache.hop.base.LoadSaveBase.validateLoadedMeta(LoadSaveBase.java:192)
at org.apache.hop.pipeline.transforms.loadsave.LoadSaveTester.testXmlRoundTrip(LoadSaveTester.java:221)
at org.apache.hop.pipeline.transforms.loadsave.LoadSaveTester.testSerialization(LoadSaveTester.java:182)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pscigala edited a comment on pull request #1298: [HOP-3606] Disabled java 11 tests
Posted by GitBox <gi...@apache.org>.
pscigala edited a comment on pull request #1298:
URL: https://github.com/apache/hop/pull/1298#issuecomment-1023729719
After investigation build failure reason seems that '-illegal-access=permit' defined already in root pom.xml seems to work well and causes exactly that 'error' like warning which is not real build failure cause.
The real cause is in hop-transform-checksum CheckSumMetaTest.testSerialization
```
...
[ERROR] Tests run: 4, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 5.091 s <<< FAILURE! - in org.apache.hop.pipeline.transforms.checksum.CheckSumMetaTest
...
'Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project hop-transform-checksum: There are test failures. '
```
The test was not marked as @Ignored before.
At first glance the test runs well on local machine. But then I tried to run it multiple times and it started failing after few repeats in a non deterministic way. Maybe this case needs separate bugfix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org