You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/04/21 11:33:18 UTC
[PR] [SPARK-55910][SQL][TESTS][FOLLOWUP] Replace SQLTestUtils/SQLTestUtilsBase with QueryTest/QueryTestBase [spark]
zhengruifeng opened a new pull request, #55445:
URL: https://github.com/apache/spark/pull/55445
### What changes were proposed in this pull request?
Followup to SPARK-55910. Migrate all call sites from the empty alias traits `SQLTestUtils`/`SQLTestUtilsBase` and the `SQLTestUtils.compareAnswers` alias to `QueryTest`/`QueryTestBase` and `QueryTest.compareAnswers` directly, and delete the alias file `sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala`.
Mechanical changes across 68 files:
- `extends/with SQLTestUtils` -> `extends/with QueryTest` (and dropped duplicates when `QueryTest` was already in the parent list)
- `extends/with SQLTestUtilsBase` -> `extends/with QueryTestBase`
- `SQLTestUtils.compareAnswers` -> `QueryTest.compareAnswers`
- Import lines rewritten to `org.apache.spark.sql.{QueryTest, QueryTestBase}` (different package from the old aliases)
- Updated two stale `SQLTestUtils`/`SQLTestUtilsBase` mentions in code comments
### Why are the changes needed?
Finishes the consolidation started in SPARK-55910 by removing the now-empty alias trait/object and having all test suites reference the canonical `QueryTest`/`QueryTestBase` in `org.apache.spark.sql`.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
Locally compiled `sql/Test/compile`, `hive/Test/compile`, `protobuf/Test/compile`, and `pipelines/Test/compile` successfully. Relying on CI for full test run.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56560][SQL][TESTS] Replace SQLTestUtils/SQLTestUtilsBase with QueryTest/QueryTestBase [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #55445:
URL: https://github.com/apache/spark/pull/55445#issuecomment-4292130907
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56560][SQL][TESTS] Replace SQLTestUtils/SQLTestUtilsBase with QueryTest/QueryTestBase [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #55445: [SPARK-56560][SQL][TESTS] Replace SQLTestUtils/SQLTestUtilsBase with QueryTest/QueryTestBase
URL: https://github.com/apache/spark/pull/55445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org