[jira] Commented: (COUCHDB-833) Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace

["Chris Anderson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891477#action_12891477 ] 

Chris Anderson commented on COUCHDB-833:
----------------------------------------

patch doesn't apply cleanly (might be because I did the json2.js update beforehand direct from json.org)

Can you repost the patch against latest trunk, or a link to your git repo so I can clone directly?

Thanks!

Chris

> Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace
> -----------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-833
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-833
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Futon
>            Reporter: Devin Torres
>            Priority: Trivial
>         Attachments: better_js_sha1.patch
>
>   Original Estimate: 0.02h
>  Remaining Estimate: 0.02h
>
> The current implementation by Paj is slow and pollutes the global namespace with variables and functions. This implementation only exports the SHA1 module  and also happens to be up to 3 times faster as an added bonus. See http://bit.ly/9wjjRG for benchmarks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.