You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "liming30 (via GitHub)" <gi...@apache.org> on 2023/04/17 03:50:27 UTC
[GitHub] [incubator-paimon] liming30 opened a new pull request, #922: [format] Fix the issue of OrcWriterFactoryTest#testNotOverrideInMemoryManager NullPointerException in unit test.
liming30 opened a new pull request, #922:
URL: https://github.com/apache/incubator-paimon/pull/922
### Purpose
[format] Fix the issue of OrcWriterFactoryTest#testNotOverrideInMemoryManager NullPointerException in unit test. #921
### Tests
No.
### API and Format
No.
### Documentation
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liming30 commented on pull request #922: [format] Fix the issue of OrcWriterFactoryTest#testNotOverrideInMemoryManager NullPointerException in unit test.
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on PR #922:
URL: https://github.com/apache/incubator-paimon/pull/922#issuecomment-1514095308
@tsreaper Is this mr worthy of being merged? We're using `writerProperties` [here](https://github.com/apache/incubator-paimon/blob/master/paimon-format/src/main/java/org/apache/paimon/format/orc/OrcWriterFactory.java#L102), but we never check if `writerProperties` is `null`, which makes it easy to make a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liming30 commented on pull request #922: [format] Fix the issue of OrcWriterFactoryTest#testNotOverrideInMemoryManager NullPointerException in unit test.
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on PR #922:
URL: https://github.com/apache/incubator-paimon/pull/922#issuecomment-1511213931
> lz4 for parquet requires native libraries. I would suggest changing lz4 compressions in tests to snappy or something else.
@tsreaper I also initiated a new issue about lz4（https://github.com/apache/incubator-paimon/issues/923）. Should I fix both issues in this one issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] tsreaper commented on pull request #922: [format] Fix the issue of OrcWriterFactoryTest#testNotOverrideInMemoryManager NullPointerException in unit test.
Posted by "tsreaper (via GitHub)" <gi...@apache.org>.
tsreaper commented on PR #922:
URL: https://github.com/apache/incubator-paimon/pull/922#issuecomment-1511236399
> > lz4 for parquet requires native libraries. I would suggest changing lz4 compressions in tests to snappy or something else.
>
> @tsreaper I also initiated a new issue about lz4 #923 . Should I fix both issues in this one issue?
I've reverted that PR so that it won't block other tests. The original issue #889 is now reopened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] tsreaper commented on pull request #922: [format] Fix the issue of OrcWriterFactoryTest#testNotOverrideInMemoryManager NullPointerException in unit test.
Posted by "tsreaper (via GitHub)" <gi...@apache.org>.
tsreaper commented on PR #922:
URL: https://github.com/apache/incubator-paimon/pull/922#issuecomment-1511157035
lz4 requires native libraries. I would suggest changing lz4 compressions in tests to snappy or something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #922: [format] Fix the issue of OrcWriterFactoryTest#testNotOverrideInMemoryManager NullPointerException in unit test.
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #922:
URL: https://github.com/apache/incubator-paimon/pull/922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org