You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 18:00:16 UTC

[GitHub] [arrow-rs] paddyhoran commented on a diff in pull request #2965: Move `byte_size` from datafusion::physical_expr

paddyhoran commented on code in PR #2965:
URL: https://github.com/apache/arrow-rs/pull/2965#discussion_r1008318683


##########
arrow-array/src/record_batch.rs:
##########
@@ -377,6 +377,14 @@ impl RecordBatch {
         let schema = Arc::new(Schema::new(fields));
         RecordBatch::try_new(schema, columns)
     }
+
+    /// Returns the total number of bytes of memory occupied physically by this batch.
+    pub fn byte_size(&self) -> usize {

Review Comment:
   I think this distinction is good (data vs data + schema).  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org