You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/05/17 07:38:49 UTC
[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10439
Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................
[kudu CLI] KUDU-2443 fix replica movement for RF=1
During replica replacement, if the leader replica is being replaced,
do not ask it to step down until the newly added replica transitions
into a voter role. Otherwise, that might prevent tablet copying to
finish successfully under racy conditions in case of replication
factor of 1.
This changelist also contains a small clean-up in tool_action_tablet.cc,
where the clean-up does not contain any functional changes.
Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 27 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/10439/1
--
To view, visit http://gerrit.cloudera.org:8080/10439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10439 )
Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................
[kudu CLI] KUDU-2443 fix replica movement for RF=1
During replica replacement, if the leader replica is being replaced,
do not ask it to step down until the newly added replica transitions
into a voter role. Otherwise, that might prevent tablet copying to
finish successfully under racy conditions in case of replication
factor of 1.
The workaround described above works OK for the case of moving/replacing
replicas in the context of KUDU-2443. The core of the underlying issue
will be addressed separately: see KUDU-2446 for details.
This changelist also contains a small clean-up in tool_action_tablet.cc
(the clean-up itself does not contain any functional changes).
Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Reviewed-on: http://gerrit.cloudera.org:8080/10439
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 28 insertions(+), 15 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10439 )
Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 17 May 2018 23:47:58 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10439 )
Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................
Patch Set 1: Code-Review+1
I don't think tablet copy should fail if the leader steps down. I'm OK with committing this workaround if we file a separate JIRA to track that problem.
--
To view, visit http://gerrit.cloudera.org:8080/10439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 17 May 2018 21:12:20 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10439
to look at the new patch set (#2).
Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................
[kudu CLI] KUDU-2443 fix replica movement for RF=1
During replica replacement, if the leader replica is being replaced,
do not ask it to step down until the newly added replica transitions
into a voter role. Otherwise, that might prevent tablet copying to
finish successfully under racy conditions in case of replication
factor of 1.
The workaround described above works OK for the case of moving/replacing
replicas in the context of KUDU-2443. The core of the underlying issue
will be addressed separately: see KUDU-2446 for details.
This changelist also contains a small clean-up in tool_action_tablet.cc
(the clean-up itself does not contain any functional changes).
Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 28 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/10439/2
--
To view, visit http://gerrit.cloudera.org:8080/10439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10439 )
Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................
Patch Set 1:
> I don't think tablet copy should fail if the leader steps down. I'm
> OK with committing this workaround if we file a separate JIRA to
> track that problem.
I filed https://issues.apache.org/jira/browse/KUDU-2446 to clarify on the case and do a proper (most likely, server-side one) fix.
--
To view, visit http://gerrit.cloudera.org:8080/10439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 17 May 2018 21:40:13 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10439 )
Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................
Patch Set 2:
> Build Successful
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/13529/ : SUCCESS
I think I'll add a test in a separate changelist.
--
To view, visit http://gerrit.cloudera.org:8080/10439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 19 May 2018 19:36:22 +0000
Gerrit-HasComments: No