You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/26 11:35:31 UTC
[GitHub] [airflow] potiuk opened a new pull request #21124: Add back legacy .piprc customization for pip
potiuk opened a new pull request #21124:
URL: https://github.com/apache/airflow/pull/21124
This change brings back backwards compatibility to using .piprc
to customize Airflow Image. Some older vrsions of pip used .piprc
(even though documentation about is difficult to find now) and we
used to support this option. With #20445, we changed to use
(fully documented) ``pip.conf`` option, however if someone used
.piprc before to customize their image, this change would break it.
The PR brings back also the .piprc option to the image (even if
it is not really clear whether current and future versions of pip
will support it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #21124: Add back legacy .piprc customization for pip
Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #21124:
URL: https://github.com/apache/airflow/pull/21124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21124: Add back legacy .piprc customization for pip
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21124:
URL: https://github.com/apache/airflow/pull/21124#issuecomment-1022117146
@jedcunningham - as discussed - we should cherry-pick that change for 2.1.4 to make sure there are no backwards-compaatibility problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21124: Add back legacy .piprc customization for pip
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21124:
URL: https://github.com/apache/airflow/pull/21124#issuecomment-1022393500
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org