You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "HonahX (via GitHub)" <gi...@apache.org> on 2024/12/09 07:04:34 UTC
[PR] Core: Parsing and Writing Tests for V3 Metadata [iceberg]
HonahX opened a new pull request, #11730:
URL: https://github.com/apache/iceberg/pull/11730
Fixes #10764
- Add new fields: `row-lineage` and `next-row-id` to TableMetadata
- Update the parser to parse v3 new fields
- Add new unit tests for V3 metadata
- Refactor TableMetadata tests by parametrizing table format versions in all tests
Not included:
- Support for `unknown` V3 schema data type
- Support for `source-ids` for V3 partition spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Parsing and Writing Tests for V3 Metadata [iceberg]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX closed pull request #11730: Core: Parsing and Writing Tests for V3 Metadata
URL: https://github.com/apache/iceberg/pull/11730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Parsing and Writing Tests for V3 Metadata [iceberg]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #11730:
URL: https://github.com/apache/iceberg/pull/11730#discussion_r1875481834
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -307,6 +311,13 @@ public String toString() {
Preconditions.checkArgument(
metadataFileLocation == null || changes.isEmpty(),
"Cannot create TableMetadata with a metadata location and changes");
+ Preconditions.checkArgument(
+ !rowLineageEnabled || formatVersion == 3,
+ "Row lineage is only supported in v3 (current version v%s)",
+ formatVersion);
+ Preconditions.checkArgument(
+ !rowLineageEnabled || nextRowId >= 0,
Review Comment:
Theoretically, `next-row-id` can start from any integer, including negative ones. I am thinking may be in the implementation we could make it starts from 0 to simplify the implementation and make it more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org