You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2025/01/17 18:13:58 UTC
[I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
amoeba opened a new issue, #45297:
URL: https://github.com/apache/arrow/issues/45297
### Describe the bug, including details regarding any error messages, version, and platform.
During the vcpkg port update for Arrow 19.0.0, an issue with the x64-windows-static build was caught. From https://github.com/microsoft/vcpkg/pull/43303#issuecomment-2597509506,
```
Installing 98/98 arrow[acero,compute,core,csv,dataset,example,filesystem,flight,flightsql,gcs,json,mimalloc,orc,parquet,s3]:x64-windows-static@19.0.0...
Building arrow[acero,compute,core,csv,dataset,example,filesystem,flight,flightsql,gcs,json,mimalloc,orc,parquet,s3]:x64-windows-static@19.0.0...
...
-- Performing post-build validation
E:\arrow-19.0.0\ports\arrow\portfile.cmake: warning: binaries built by this port link with C RunTimes ("CRTs") inconsistent with those requested by the triplet and deployment structure. If the triplet is intended to only use the release CRT, you should add set(VCPKG_POLICY_ONLY_RELEASE_CRT enabled) to the triplet .cmake file. To suppress this check entirely, add set(VCPKG_POLICY_SKIP_CRT_LINKAGE_CHECK enabled) to the triplet .cmake if this is triplet-wide, or to portfile.cmake if this is specific to the port. You can inspect the binaries with: dumpbin.exe /directives mylibfile.lib
E:\arrow-19.0.0\packages\arrow_x64-windows-static: note: the binaries are relative to ${CURRENT_PACKAGES_DIR} here
note: The following binaries should link with only: Static Debug (/MTd)
note: debug/lib/arrow_bundled_dependencies.lib links with: Dynamic Debug (/MDd)
note: The following binaries should link with only: Static Release (/MT)
note: lib/arrow_bundled_dependencies.lib links with: Dynamic Release (/MD)
E:\arrow-19.0.0\ports\arrow\portfile.cmake: warning: Found 1 post-build check problem(s). These are usually caused by bugs in portfile.cmake or the upstream build system. Please correct these before submitting this port to the curated registry.
...
```
We'll have to address these to update vcpkg for 19.0.0.
cc @kou @assignUser @raulcd
### Component(s)
Release, Packaging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-2601128997
> Should we make a tracking issue for the FetchContent migration? I think there are now at least two related issues (this and [#45195](https://github.com/apache/arrow/issues/45195)).
Yes. It'll be helpful.
FYI: One more related issue: #45063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-2601142080
Thanks! Done: https://github.com/apache/arrow/issues/45303. I'm not sure I understand all that past discussion or the task as well as others might so please feel free to add anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-2599789234
Two other thoughts:
1. Do we need/want to merge this into Arrow?
2. We could make the above patch more specific, like by testing `if(VCPKG_CRT_LINKAGE STREQUAL "static")` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-4251175025
@amoeba @kou do you know if this is still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-2601123069
It'll work but migrating to FetchContent from ExternalProject is better.
How about using the change in vcpkg for now and migrating to FetchCotent before Apache Arrow C++ 20.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-2601126530
Thanks for taking a look @kou. Using this patch for Arrow 19.0.0 sounds good.
Should we make a tracking issue for the FetchContent migration? I think there are now at least two related issues (this and https://github.com/apache/arrow/issues/45195).
For now I'll integrate this patch into the vcpkg port and update the issue body here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-2599786414
Adding this patch to our vcpkg port made the post-build validation warning go away,
```patch
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index abfe6d274f..8bacfe89af 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -886,9 +886,17 @@ foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
set(EP_CXX_FLAGS_${CONFIG} "${CMAKE_CXX_FLAGS_${CONFIG}}")
set(EP_C_FLAGS_${CONFIG} "${CMAKE_C_FLAGS_${CONFIG}}")
if(CONFIG STREQUAL DEBUG)
- set(EP_MSVC_RUNTIME_LIBRARY MultiThreadedDebugDLL)
+ if(BUILD_SHARED_LIBS)
+ set(EP_MSVC_RUNTIME_LIBRARY MultiThreadedDebugDLL)
+ else()
+ set(EP_MSVC_RUNTIME_LIBRARY MultiThreadedDebug)
+ endif()
else()
- set(EP_MSVC_RUNTIME_LIBRARY MultiThreadedDLL)
+ if(BUILD_SHARED_LIBS)
+ set(EP_MSVC_RUNTIME_LIBRARY MultiThreadedDLL)
+ else()
+ set(EP_MSVC_RUNTIME_LIBRARY MultiThreaded)
+ endif()
endif()
string(APPEND EP_CXX_FLAGS_${CONFIG}
" ${CMAKE_CXX_COMPILE_OPTIONS_MSVC_RUNTIME_LIBRARY_${EP_MSVC_RUNTIME_LIBRARY}}")
```
I'm going to test other triplets now too. I'm not sure if the patch is perfect yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release][Packaging] Address notes in vcpkg x64-windows-static build [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #45297:
URL: https://github.com/apache/arrow/issues/45297#issuecomment-4254615853
Yes I think so. I had to refresh my memory but I think we want to remove the patch from the vcpkg but we prefer to block that removal on continuing the migration of ThirdpartyToolchain.cmake from EP to FC. Basically, anything that depends on `EP_{C,CXX}_FLAGS_*`. I think you already did all of the most difficult migrations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org